You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/11/19 17:03:15 UTC

[GitHub] [skywalking-python] tom-pytel commented on a change in pull request #83: Refactor: moved exception check to Span.__exit__

tom-pytel commented on a change in pull request #83:
URL: https://github.com/apache/skywalking-python/pull/83#discussion_r527049684



##########
File path: skywalking/trace/span.py
##########
@@ -117,6 +117,8 @@ def __enter__(self):
         return self
 
     def __exit__(self, exc_type, exc_val, exc_tb):
+        if isinstance(exc_type, BaseException):
+            self.raised()

Review comment:
       No this will not stop propagation.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org