You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/02/16 19:24:34 UTC
[GitHub] [hbase] apurtell commented on a change in pull request #4038: HBASE-26552 Introduce retry to logroller to avoid abort
apurtell commented on a change in pull request #4038:
URL: https://github.com/apache/hbase/pull/4038#discussion_r808377557
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java
##########
@@ -114,6 +122,8 @@ protected AbstractWALRoller(String name, Configuration conf, T abortable) {
this.threadWakeFrequency = conf.getInt(HConstants.THREAD_WAKE_FREQUENCY, 10 * 1000);
this.checkLowReplicationInterval =
conf.getLong("hbase.regionserver.hlog.check.lowreplication.interval", 30 * 1000);
+ this.rollWaitTimeout = conf.getLong(WAL_ROLL_WAIT_TIMEOUT, 30000);
+ this.maxRollRetry = conf.getInt(WAL_ROLL_RETRIES, 2);
Review comment:
Can we have this default be 0, which means do not retry, to preserve existing behavior and expectations? Otherwise lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org