You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "mvzink (via GitHub)" <gi...@apache.org> on 2024/11/28 02:21:31 UTC

[PR] Support parsing optional nulls handling for unique constraint [datafusion-sqlparser-rs]

mvzink opened a new pull request, #1567:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1567

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Support parsing optional nulls handling for unique constraint [datafusion-sqlparser-rs]

Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio commented on code in PR #1567:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1567#discussion_r1862450915


##########
tests/sqlparser_postgres.rs:
##########
@@ -594,6 +594,13 @@ fn parse_alter_table_constraints_rename() {
     }
 }
 
+#[test]
+fn parse_alter_table_constraints_unique_nulls_distinct() {
+    pg_and_generic().verified_stmt("ALTER TABLE t ADD CONSTRAINT b UNIQUE NULLS NOT DISTINCT (c)");

Review Comment:
   For one of the test cases can we include an assertion on the AST, like in [this style](https://github.com/apache/datafusion-sqlparser-rs/blob/a54331889874ca896100b6666720d6fcb43b6965/tests/sqlparser_postgres.rs#L882-L888)? just to sanity check where in the statement the nulls option ends up in the tree



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Support parsing optional nulls handling for unique constraint [datafusion-sqlparser-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #1567:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1567


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Support parsing optional nulls handling for unique constraint [datafusion-sqlparser-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #1567:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1567#issuecomment-2515917317

   Looks good to me -- feel free to merge the PRs in yourself @iffyio  as well -- I appreciate the heads up, but you should totally feel empowered to merge directly yourself too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org