[GitHub] [hive] pvary commented on a change in pull request #1232: HIVE-23560 : Optimize bootstrap dump to abort only write Transactions

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #1232:
URL: https://github.com/apache/hive/pull/1232#discussion_r457149267



##########
File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -2802,6 +2806,7 @@ PartitionsResponse get_partitions_req(1:PartitionsRequest req)
 
   void add_replication_metrics(1: ReplicationMetricList replicationMetricList) throws(1:MetaException o1)
   ReplicationMetricList get_replication_metrics(1: GetReplicationMetricsRequest rqst) throws(1:MetaException o1)
+  GetOpenTxnsResponse get_open_txns_req(1: GetOpenTxnsRequest getOpenTxnsRequest)

Review comment:
       Why did you introduce a new HMS API method for this?
   
   I would add a new type attribute to TxnInfo and use get_open_txns_info instead




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org