You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by manuzhang <gi...@git.apache.org> on 2018/05/01 15:35:37 UTC
[GitHub] incubator-gearpump pull request #245: [WIP] Upickle -> Json4s
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/245
[WIP] Upickle -> Json4s
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit message is formatted like:
`[GEARPUMP-<Jira issue #>] Meaningful description of pull request`
- [ ] Make sure tests pass via `sbt clean test`.
- [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/incubator-gearpump json4s
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/245.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #245
----
commit 2a640a41d9424a53ccd43082c821c85cf78eeca2
Author: manuzhang <ow...@...>
Date: 2018-04-30T06:23:19Z
[WIP] Upickle -> Json4s
----
---
[GitHub] incubator-gearpump issue #245: [WIP] Upickle -> Json4s
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/245
# [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/245?src=pr&el=h1) Report
> Merging [#245](https://codecov.io/gh/apache/incubator-gearpump/pull/245?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/5cce13addd646d144748f12c48010de0c0b9d02b?src=pr&el=desc) will **increase** coverage by `0.5%`.
> The diff coverage is `87.71%`.
```diff
@@ Coverage Diff @@
## master #245 +/- ##
=========================================
+ Coverage 69.07% 69.57% +0.5%
=========================================
Files 192 192
Lines 6166 6186 +20
Branches 540 521 -19
=========================================
+ Hits 4259 4304 +45
+ Misses 1907 1882 -25
```
---