You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/28 14:52:58 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new issue #1144: Crtical section should be replaced with semaphore or spinlock as much as we can to improve SMP performance

xiaoxiang781216 opened a new issue #1144:
URL: https://github.com/apache/incubator-nuttx/issues/1144


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #1144: Crtical section should be replaced with semaphore or spinlock as much as we can to improve SMP performance

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #1144:
URL: https://github.com/apache/incubator-nuttx/issues/1144#issuecomment-721553181


   related issue: https://github.com/apache/incubator-nuttx/issues/2213


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #1144: Crtical section should be replaced with semaphore or spinlock as much as we can to improve SMP performance

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #1144:
URL: https://github.com/apache/incubator-nuttx/issues/1144#issuecomment-807159902


   Once special case: replace the critical section with the spin lock if the caller doesn't sleep inside it, because:
   
   1. Can't wait inside the spinlock
   2. Can wait inside the critical section
   
   To support the wait, the critical section has much more complex logic than spinlock. All code which don't require sleep is better to switch to spinlock.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org