You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ni...@apache.org on 2016/08/04 14:23:54 UTC
svn commit: r1755192 - in /poi/trunk/src: java/org/apache/poi/util/
testcases/org/apache/poi/util/
Author: nick
Date: Thu Aug 4 14:23:54 2016
New Revision: 1755192
URL: http://svn.apache.org/viewvc?rev=1755192&view=rev
Log:
Whitespace, javadocs and @Overrides for the Logger classes
Modified:
poi/trunk/src/java/org/apache/poi/util/CommonsLogger.java
poi/trunk/src/java/org/apache/poi/util/NullLogger.java
poi/trunk/src/java/org/apache/poi/util/SystemOutLogger.java
poi/trunk/src/testcases/org/apache/poi/util/DummyPOILogger.java
poi/trunk/src/testcases/org/apache/poi/util/TestPOILogger.java
Modified: poi/trunk/src/java/org/apache/poi/util/CommonsLogger.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/util/CommonsLogger.java?rev=1755192&r1=1755191&r2=1755192&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/util/CommonsLogger.java (original)
+++ poi/trunk/src/java/org/apache/poi/util/CommonsLogger.java Thu Aug 4 14:23:54 2016
@@ -27,19 +27,13 @@ import org.apache.commons.logging.LogFac
* developers to write log calls, while simultaneously making those
* calls as cheap as possible by performing lazy evaluation of the log
* message.<p>
- *
- * @author Marc Johnson (mjohnson at apache dot org)
- * @author Glen Stampoultzis (glens at apache.org)
- * @author Nicola Ken Barozzi (nicolaken at apache.org)
*/
-
public class CommonsLogger extends POILogger
{
-
private static LogFactory _creator = LogFactory.getFactory();
private Log log = null;
-
+ @Override
public void initialize(final String cat)
{
this.log = _creator.getInstance(cat);
@@ -51,6 +45,7 @@ public class CommonsLogger extends POILo
* @param level One of DEBUG, INFO, WARN, ERROR, FATAL
* @param obj1 The object to log.
*/
+ @Override
public void log(final int level, final Object obj1)
{
if(level==FATAL)
@@ -104,6 +99,7 @@ public class CommonsLogger extends POILo
* @param obj1 The object to log. This is converted to a string.
* @param exception An exception to be logged
*/
+ @Override
public void log(final int level, final Object obj1,
final Throwable exception)
{
@@ -175,7 +171,7 @@ public class CommonsLogger extends POILo
*
* @param level One of DEBUG, INFO, WARN, ERROR, FATAL
*/
-
+ @Override
public boolean check(final int level)
{
if(level==FATAL)
Modified: poi/trunk/src/java/org/apache/poi/util/NullLogger.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/util/NullLogger.java?rev=1755192&r1=1755191&r2=1755192&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/util/NullLogger.java (original)
+++ poi/trunk/src/java/org/apache/poi/util/NullLogger.java Thu Aug 4 14:23:54 2016
@@ -22,14 +22,10 @@ package org.apache.poi.util;
* developers to write log calls, while simultaneously making those
* calls as cheap as possible by performing lazy evaluation of the log
* message.<p>
- *
- * @author Marc Johnson (mjohnson at apache dot org)
- * @author Glen Stampoultzis (glens at apache.org)
- * @author Nicola Ken Barozzi (nicolaken at apache.org)
*/
public class NullLogger extends POILogger {
@Override
- public void initialize(final String cat){
+ public void initialize(final String cat) {
// do nothing
}
@@ -41,8 +37,7 @@ public class NullLogger extends POILogge
*/
@Override
- public void log(final int level, final Object obj1)
- {
+ public void log(final int level, final Object obj1) {
// do nothing
}
@@ -53,6 +48,7 @@ public class NullLogger extends POILogge
* @param obj1 The object to log. This is converted to a string.
* @param exception An exception to be logged
*/
+ @Override
public void log(int level, Object obj1, final Throwable exception) {
// do nothing
}
Modified: poi/trunk/src/java/org/apache/poi/util/SystemOutLogger.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/util/SystemOutLogger.java?rev=1755192&r1=1755191&r2=1755192&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/util/SystemOutLogger.java (original)
+++ poi/trunk/src/java/org/apache/poi/util/SystemOutLogger.java Thu Aug 4 14:23:54 2016
@@ -24,15 +24,12 @@ package org.apache.poi.util;
* developers to write log calls, while simultaneously making those
* calls as cheap as possible by performing lazy evaluation of the log
* message.
- *
- * @author Marc Johnson (mjohnson at apache dot org)
- * @author Glen Stampoultzis (glens at apache.org)
- * @author Nicola Ken Barozzi (nicolaken at apache.org)
*/
public class SystemOutLogger extends POILogger
{
private String _cat;
+ @Override
public void initialize(final String cat)
{
this._cat=cat;
@@ -44,7 +41,7 @@ public class SystemOutLogger extends POI
* @param level One of DEBUG, INFO, WARN, ERROR, FATAL
* @param obj1 The object to log.
*/
-
+ @Override
public void log(final int level, final Object obj1)
{
log(level, obj1, null);
@@ -57,6 +54,7 @@ public class SystemOutLogger extends POI
* @param obj1 The object to log. This is converted to a string.
* @param exception An exception to be logged
*/
+ @Override
@SuppressForbidden("uses printStackTrace")
public void log(final int level, final Object obj1,
final Throwable exception) {
@@ -78,6 +76,7 @@ public class SystemOutLogger extends POI
* @see #ERROR
* @see #FATAL
*/
+ @Override
public boolean check(final int level)
{
int currentLevel;
Modified: poi/trunk/src/testcases/org/apache/poi/util/DummyPOILogger.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/util/DummyPOILogger.java?rev=1755192&r1=1755191&r2=1755192&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/util/DummyPOILogger.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/util/DummyPOILogger.java Thu Aug 4 14:23:54 2016
@@ -30,16 +30,20 @@ public class DummyPOILogger extends POIL
logged = new ArrayList<String>();
}
+ @Override
public boolean check(int level) {
return true;
}
+ @Override
public void initialize(String cat) {}
+ @Override
public void log(int level, Object obj1) {
logged.add(level + " - " + obj1);
}
+ @Override
public void log(int level, Object obj1, Throwable exception) {
logged.add(level + " - " + obj1 + " - " + exception);
}
Modified: poi/trunk/src/testcases/org/apache/poi/util/TestPOILogger.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/util/TestPOILogger.java?rev=1755192&r1=1755191&r2=1755192&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/util/TestPOILogger.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/util/TestPOILogger.java Thu Aug 4 14:23:54 2016
@@ -26,10 +26,6 @@ import org.junit.Test;
/**
* Tests the log class.
- *
- * @author Glen Stampoultzis (glens at apache.org)
- * @author Marc Johnson (mjohnson at apache dot org)
- * @author Nicola Ken Barozzi (nicolaken at apache.org)
*/
public final class TestPOILogger extends POILogger {
private String lastLog = "";
@@ -61,20 +57,26 @@ public final class TestPOILogger extends
POILogFactory._loggerClassName = oldLCN;
}
}
+
+ // ---------- POI Logger methods implemented for testing ----------
+ @Override
public void initialize(String cat) {
}
+ @Override
public void log(int level, Object obj1) {
lastLog = (obj1 == null) ? "" : obj1.toString();
lastEx = null;
}
+ @Override
public void log(int level, Object obj1, Throwable exception) {
lastLog = (obj1 == null) ? "" : obj1.toString();
lastEx = exception;
}
+ @Override
public boolean check(int level) {
return true;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org