[GitHub] Fokko commented on issue #3475: [AIRFLOW-2315] Improve S3Hook

[GitBox <gi...@apache.org>]

Fokko commented on issue #3475: [AIRFLOW-2315] Improve S3Hook
URL: https://github.com/apache/incubator-airflow/pull/3475#issuecomment-410255815
 
 
   The tests are still red:
   ```
   ======================================================================
   25) ERROR: test_execute (tests.contrib.operators.test_gcs_to_s3_operator.GoogleCloudStorageToS3OperatorTest)
   ----------------------------------------------------------------------
      Traceback (most recent call last):
       .tox/py27-backend_mysql/lib/python2.7/site-packages/moto/core/models.py line 70 in wrapper
         result = func(*args, **kwargs)
       .tox/py27-backend_mysql/lib/python2.7/site-packages/mock/mock.py line 1305 in patched
         return func(*args, **keywargs)
       tests/contrib/operators/test_gcs_to_s3_operator.py line 70 in test_execute
         uploaded_files = operator.execute(None)
       airflow/contrib/operators/gcs_to_s3.py line 107 in execute
         replace=self.replace)
       airflow/hooks/S3_hook.py line 379 in load_bytes
         upload_args)
       airflow/hooks/S3_hook.py line 425 in _prepare_load
         connection_object = self.get_connection(self.aws_conn_id)
       airflow/hooks/base_hook.py line 80 in get_connection
         conn = random.choice(cls.get_connections(conn_id))
       airflow/hooks/base_hook.py line 71 in get_connections
         conn = cls._get_connection_from_env(conn_id)
       airflow/hooks/base_hook.py line 63 in _get_connection_from_env
         environment_uri = os.environ.get(CONN_ENV_PREFIX + conn_id.upper())
      AttributeError: 'NoneType' object has no attribute 'upper'
   ```
   
   Could you rebase onto master? Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services