You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/02/26 02:32:49 UTC
[GitHub] codecov-io commented on issue #3885: Actively check cluster changes
if there is no callback for a long time
codecov-io commented on issue #3885: Actively check cluster changes if there is no callback for a long time
URL: https://github.com/apache/incubator-pinot/pull/3885#issuecomment-467268993
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3885?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@4e7ffb3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `87.91%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/3885?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3885 +/- ##
=========================================
Coverage ? 67.19%
Complexity ? 4
=========================================
Files ? 1031
Lines ? 50823
Branches ? 7099
=========================================
Hits ? 34151
Misses ? 14339
Partials ? 2333
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3885?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...esthandler/ConnectionPoolBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQ29ubmVjdGlvblBvb2xCcm9rZXJSZXF1ZXN0SGFuZGxlci5qYXZh) | `88.27% <100%> (ø)` | `0 <0> (?)` | |
| [...broker/broker/helix/ExternalViewChangeHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0V4dGVybmFsVmlld0NoYW5nZUhhbmRsZXIuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...a/org/apache/pinot/common/metrics/BrokerTimer.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJUaW1lci5qYXZh) | `88.88% <100%> (ø)` | `0 <0> (?)` | |
| [...oker/broker/helix/InstanceConfigChangeHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0luc3RhbmNlQ29uZmlnQ2hhbmdlSGFuZGxlci5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...a/org/apache/pinot/common/metrics/BrokerMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJNZXRlci5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...pache/pinot/broker/broker/BrokerServerBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0Jyb2tlclNlcnZlckJ1aWxkZXIuamF2YQ==) | `91.07% <100%> (ø)` | `0 <0> (?)` | |
| [.../pinot/broker/broker/helix/HelixBrokerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0hlbGl4QnJva2VyU3RhcnRlci5qYXZh) | `73.5% <100%> (ø)` | `0 <0> (?)` | |
| [...broker/broker/helix/LiveInstanceChangeHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0xpdmVJbnN0YW5jZUNoYW5nZUhhbmRsZXIuamF2YQ==) | `65.9% <75%> (ø)` | `0 <0> (?)` | |
| [...not/broker/broker/helix/ClusterChangeMediator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0NsdXN0ZXJDaGFuZ2VNZWRpYXRvci5qYXZh) | `82.14% <84.78%> (ø)` | `0 <0> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3885?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3885?src=pr&el=footer). Last update [4e7ffb3...1aae0ea](https://codecov.io/gh/apache/incubator-pinot/pull/3885?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org