You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Dan Dumont <dd...@us.ibm.com> on 2011/11/14 22:56:50 UTC
Review Request: Adding sample gadget to demo dynamic height and width
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2826/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
Just adding a sample gadget here.
For these types of changes, would you rather me just commit them, once my account is all set up and granted access? Or would you rather reviews go in for them. I'm fine with either.
Diffs
-----
https://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/DynamicSizeDemo.xml PRE-CREATION
Diff: https://reviews.apache.org/r/2826/diff
Testing
-------
Loaded the gadget in a test container... pressed the buttons :)
Thanks,
Dan
Re: Review Request: Adding sample gadget to demo dynamic height and width
Posted by Paul Lindner <li...@inuus.com>.
I agree let's CTR for changes light this where you're not looking for
feedback.
On Tue, Nov 15, 2011 at 6:25 AM, Dan Dumont <dd...@us.ibm.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2826/#review3257
> -----------------------------------------------------------
>
> Ship it!
>
>
> Committed r1202203.
>
> - Dan
>
>
> On 2011-11-14 21:56:50, Dan Dumont wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/2826/
> > -----------------------------------------------------------
> >
> > (Updated 2011-11-14 21:56:50)
> >
> >
> > Review request for shindig.
> >
> >
> > Summary
> > -------
> >
> > Just adding a sample gadget here.
> > For these types of changes, would you rather me just commit them, once
> my account is all set up and granted access? Or would you rather reviews
> go in for them. I'm fine with either.
> >
> >
> > Diffs
> > -----
> >
> >
> https://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/DynamicSizeDemo.xmlPRE-CREATION
> >
> > Diff: https://reviews.apache.org/r/2826/diff
> >
> >
> > Testing
> > -------
> >
> > Loaded the gadget in a test container... pressed the buttons :)
> >
> >
> > Thanks,
> >
> > Dan
> >
> >
>
>
--
Paul Lindner -- lindner@inuus.com -- linkedin.com/in/plindner
Re: Review Request: Adding sample gadget to demo dynamic height and width
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2826/#review3257
-----------------------------------------------------------
Ship it!
Committed r1202203.
- Dan
On 2011-11-14 21:56:50, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2826/
> -----------------------------------------------------------
>
> (Updated 2011-11-14 21:56:50)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Just adding a sample gadget here.
> For these types of changes, would you rather me just commit them, once my account is all set up and granted access? Or would you rather reviews go in for them. I'm fine with either.
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/DynamicSizeDemo.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/2826/diff
>
>
> Testing
> -------
>
> Loaded the gadget in a test container... pressed the buttons :)
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Adding sample gadget to demo dynamic height and width
Posted by Jesse Ciancetta <jc...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2826/#review3252
-----------------------------------------------------------
Ship it!
I'd say for stuff like this (and other small localized changes which don't involve API changes or major new functionality) we can probably just commit it directly.
- Jesse
On 2011-11-14 21:56:50, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2826/
> -----------------------------------------------------------
>
> (Updated 2011-11-14 21:56:50)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Just adding a sample gadget here.
> For these types of changes, would you rather me just commit them, once my account is all set up and granted access? Or would you rather reviews go in for them. I'm fine with either.
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/DynamicSizeDemo.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/2826/diff
>
>
> Testing
> -------
>
> Loaded the gadget in a test container... pressed the buttons :)
>
>
> Thanks,
>
> Dan
>
>