You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucy.apache.org by rectang <gi...@git.apache.org> on 2016/04/21 04:39:23 UTC

[lucy-dev] [GitHub] lucy pull request: LUCY-301 C32/C64 transition

GitHub user rectang opened a pull request:

    https://github.com/apache/lucy/pull/42

    LUCY-301 C32/C64 transition

    At present, InStream, OutStream, and NumberUtils provide an unsigned compressed format called C32/C64 -- and when we need signed representations, we just cast.
    
    To get rid of all these casts (and fix some sites missing casts), support signed and unsigned variants.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rectang/lucy LUCY-301-C32-transition

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucy/pull/42.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #42
    
----
commit 8a48ef58e2592336594bebb08a25ea763f83037c
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-18T19:32:54Z

    Duplicate IO C32 as explicitly unsigned CU32.
    
    Prepare for the addition of CI32 -- a signed compressed integer.

commit 3e3c64895bc92b19fadebe2a7b3188e8a218597d
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-18T22:07:21Z

    Add explicit cu32 and cu64 to NumUtil.
    
    Duplicate the functionality of xxxx_c64 in xxxx_cu64, in preparation for
    the addition of xxxx_ci64 (for signed integers) and the eventual removal
    of xxxx_64.

commit ce89b9c40ea86b45c181852a12edeaa7bea2d054
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-18T22:43:38Z

    Read/write compressed signed integers.

commit cef8cbc1dc507196ac0881f72709031b2889abff
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-19T00:12:14Z

    Support compressed signed integers in NumberUtils.

commit 67656d94224b9350deb224699eda5956a0b8a989
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-19T00:52:42Z

    Switch NumUtils client code to cu32/ci32.
    
    Change all invocations from NumUtil_xxxx_c32 to use the
    NumUtil_xxxx_cu32 and NumUtil_xxx_ci32 variants which are explicitly
    signed or unsigned.

commit c1af09331739ee47e4a9dc138b7dd0265ba74497
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-19T01:45:19Z

    Remove obsolete NumUtil C32/C64 code.

commit cbe964dfa85720357b8e6f06347028671c641e06
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-20T01:59:15Z

    Switch Perl bindings from C32/C64 to CI32/etc.
    
    Change IO methods invoked to use explicitly signed/unsigned versions
    rather than casting.

commit 795626b6c4c6c98cd6f6ac0d0a2899e4b6e09e33
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-20T02:19:28Z

    Switch Go bindings from C32/C64 to CI32/etc.
    
    Change IO methods invoked to use explicitly signed/unsigned versions
    rather than casting.

commit 17a3d60bbe2b5a1279052278225b2875668b2968
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-20T22:29:23Z

    Change easy-to-review Read_C32 to CU32.
    
    All of these have the type of the lvalue show up in the diff, making it
    easy to confirm that the types match.

commit 5e4dcd2e31a80ed20e86ca931bbbc565f6781820
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-21T01:16:06Z

    Change size_t C32/C64 read/writes.
    
    Adapt Read_C32/Write_C32/Read_C64/Write_C64 to Read_CU32/etc for
    variables representing memory sizes: String, Blob, Vector and Hash sizes
    in particular.

commit e5ba8a19dd8e04039e7de5479b852150b7705b46
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-21T01:34:30Z

    Switch C64 to CI64 for file positions.
    
    Change Read/Write C64 to CI64 for file positions, all of which are
    represented as signed 64-bit integers.

commit 3089bfdf4c09b7cf3f937405417c93e23063d727
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-21T01:40:26Z

    Switch C32 code relating to doc IDs.
    
    Doc IDs are signed.  Delta doc IDs may signed or unsigned.  Use the
    appropriate CI32 or CU32 read/write methods for both.

commit 656a773b89d3676dc9d62d48f5a2d145342bb32c
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-21T01:52:32Z

    Change C32/C64 for freq, positions.
    
    `freq` (num occurrences per document for a term) is generally
    represented as a uint32_t.  Positions may be signed or unsigned -- it's
    not consistent.  Just match up to existing usage.

commit febd2ff3cb76b460e0778e6d732830cf1f860e50
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-21T02:01:15Z

    Misc C32/C64 transition.
    
    Transition all remaining Read/Write C32/C64 to Read_CI64/etc.

commit ab5a44bd414e79ed0a5127e303887056ce09d7cd
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2016-04-21T02:23:29Z

    Remove obsolete C32/C64 code.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[lucy-dev] [GitHub] lucy pull request: LUCY-301 C32/C64 transition

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/lucy/pull/42


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---