You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/07 05:40:09 UTC
[GitHub] [spark] cloud-fan opened a new pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
cloud-fan opened a new pull request #32800:
URL: https://github.com/apache/spark/pull/32800
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error message, please read the guideline first:
https://spark.apache.org/error-message-guidelines.html
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This is a followup of https://github.com/apache/spark/pull/32534
#32534 proposed a use case to use `DeserializedMemoryEntry` to store off-heap data, and let Spark release the memory via the `AutoCloseable` interface. However, there is one more problem: `DeserializedMemoryEntry` always reports its size as on-heap size, which is inaccurate. If the Spark cluster is configured with small on-heap size and large off-heap size, this will trigger a lot of spilling.
This PR makes `DeserializedMemoryEntry` truly support off-heap data. Now the caller side can cache off-heap data with a new storage level `OFF_HEAP_ONLY_DESER`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
correct the memory counting for off-heap data.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
updated test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-857074557
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44026/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-857455565
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139534/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-857099601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-857040834
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44025/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-857010731
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44025/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32800:
URL: https://github.com/apache/spark/pull/32800#discussion_r646284863
##########
File path: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala
##########
@@ -474,15 +475,15 @@ private[spark] class MemoryStore(
// non-blocking "tryLock" here in order to ignore blocks which are locked for reading:
if (blockInfoManager.lockForWriting(blockId, blocking = false).isDefined) {
selectedBlocks += blockId
- freedMemory += pair.getValue.size
+ freedMemory += entry.size
Review comment:
A small cleanup. We have `val entry = pair.getValue` a few lines above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-857366545
**[Test build #139534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139534/testReport)** for PR 32800 at commit [`cabebd9`](https://github.com/apache/spark/commit/cabebd922fe816acd8ccde1168dc2f0ac6d0bf56).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-855675429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32800:
URL: https://github.com/apache/spark/pull/32800#discussion_r647645615
##########
File path: core/src/main/java/org/apache/spark/api/java/StorageLevels.java
##########
@@ -36,6 +36,7 @@
public static final StorageLevel MEMORY_AND_DISK_SER = create(true, true, false, false, 1);
public static final StorageLevel MEMORY_AND_DISK_SER_2 = create(true, true, false, false, 2);
public static final StorageLevel OFF_HEAP = create(true, true, true, false, 1);
+ public static final StorageLevel OFF_HEAP_ONLY_DESER = create(false, true, true, true, 1);
Review comment:
good point. Maybe I should remove it and the vendors should construct this storage level by themselves, if they have deserialized off-heap entries.
It's not a user-facing thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-857452986
**[Test build #139534 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139534/testReport)** for PR 32800 at commit [`cabebd9`](https://github.com/apache/spark/commit/cabebd922fe816acd8ccde1168dc2f0ac6d0bf56).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #32800:
URL: https://github.com/apache/spark/pull/32800#discussion_r647639442
##########
File path: core/src/main/java/org/apache/spark/api/java/StorageLevels.java
##########
@@ -36,6 +36,7 @@
public static final StorageLevel MEMORY_AND_DISK_SER = create(true, true, false, false, 1);
public static final StorageLevel MEMORY_AND_DISK_SER_2 = create(true, true, false, false, 2);
public static final StorageLevel OFF_HEAP = create(true, true, true, false, 1);
+ public static final StorageLevel OFF_HEAP_ONLY_DESER = create(false, true, true, true, 1);
Review comment:
Do we need to document this anywhere else or is this kind or private?
Seems reasonable to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-855740358
**[Test build #139396 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139396/testReport)** for PR 32800 at commit [`55a51be`](https://github.com/apache/spark/commit/55a51be0343728b3934f96742e85af6845a90a12).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-857088911
**[Test build #139501 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139501/testReport)** for PR 32800 at commit [`a619981`](https://github.com/apache/spark/commit/a619981f53df8cf73f5504c91fe9a1c6b294e763).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-855760596
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139396/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-855651129
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43918/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-855596174
cc @xuechendi @srowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-857494776
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44060/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-857478591
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44060/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-857720101
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-857366545
**[Test build #139534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139534/testReport)** for PR 32800 at commit [`cabebd9`](https://github.com/apache/spark/commit/cabebd922fe816acd8ccde1168dc2f0ac6d0bf56).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-855618471
**[Test build #139396 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139396/testReport)** for PR 32800 at commit [`55a51be`](https://github.com/apache/spark/commit/55a51be0343728b3934f96742e85af6845a90a12).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-857455565
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139534/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #32800:
URL: https://github.com/apache/spark/pull/32800#discussion_r647807058
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -298,10 +298,12 @@ private[spark] class BlockManager(
protected def saveToDiskStore(): Unit
- private def saveDeserializedValuesToMemoryStore(inputStream: InputStream): Boolean = {
+ private def saveDeserializedValuesToMemoryStore(
+ inputStream: InputStream,
+ memoryMode: MemoryMode): Boolean = {
Review comment:
nit: seems no need to pass `memoryMode`, just follow `level.memoryMode`.
##########
File path: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala
##########
@@ -706,6 +709,7 @@ private class SerializedValuesHolder[T](
classTag: ClassTag[T],
memoryMode: MemoryMode,
serializerManager: SerializerManager) extends ValuesHolder[T] {
+
Review comment:
nit: unnecessary blank?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-856941781
also cc @viirya @Ngone51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-857099604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-856957712
**[Test build #139501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139501/testReport)** for PR 32800 at commit [`a619981`](https://github.com/apache/spark/commit/a619981f53df8cf73f5504c91fe9a1c6b294e763).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-857494776
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44060/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-857040780
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44025/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-855675429
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43918/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-856957712
**[Test build #139501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139501/testReport)** for PR 32800 at commit [`a619981`](https://github.com/apache/spark/commit/a619981f53df8cf73f5504c91fe9a1c6b294e763).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-855618471
**[Test build #139396 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139396/testReport)** for PR 32800 at commit [`55a51be`](https://github.com/apache/spark/commit/55a51be0343728b3934f96742e85af6845a90a12).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-856998328
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44026/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-857420798
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44060/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-855675388
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43918/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #32800:
URL: https://github.com/apache/spark/pull/32800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-857040834
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44025/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-857366415
> Do we have some context about why we don't support off-heap for deserialized storage before?
I'm not very sure but it seems like just a missed use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan edited a comment on pull request #32800: [SPARK-35661][SQL] Allow deserialized off-heap memory entry
Posted by GitBox <gi...@apache.org>.
cloud-fan edited a comment on pull request #32800:
URL: https://github.com/apache/spark/pull/32800#issuecomment-857720101
thanks for the review, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org