You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/07 09:13:24 UTC

[GitHub] [spark] maropu edited a comment on pull request #32037: [SPARK-34944][SQL][TESTS] Replace bigint with int for web_returns and store_returns in TPCDS tests to employ correct data type

maropu edited a comment on pull request #32037:
URL: https://github.com/apache/spark/pull/32037#issuecomment-814743523


   The citation in the PR description refers to the TPCDS v2.9 doc? http://www.tpc.org/tpc_documents_current_versions/pdf/tpc-ds_v2.9.0.pdf Could you add the link there?
   
   Btw, for better commit logs, could you write what this PR proposes clearly in the description? This PR proposes that we use `int` for `identifier` and `bigint` for `integer`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org