You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/10 04:25:27 UTC
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #337: fix: ssl need to be update when secret has been changed
codecov-io edited a comment on pull request #337:
URL: https://github.com/apache/apisix-ingress-controller/pull/337#issuecomment-817065282
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/337?src=pr&el=h1) Report
> Merging [#337](https://codecov.io/gh/apache/apisix-ingress-controller/pull/337?src=pr&el=desc) (d4ddc85) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/c6e71803cca5470679ac0433753b361753e38783?el=desc) (c6e7180) will **decrease** coverage by `0.50%`.
> The diff coverage is `0.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/337/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/337?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
- Coverage 43.98% 43.47% -0.51%
==========================================
Files 40 39 -1
Lines 3456 3457 +1
==========================================
- Hits 1520 1503 -17
- Misses 1767 1783 +16
- Partials 169 171 +2
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/337?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/controller/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/337/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci9zZWNyZXQuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/337/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `28.44% <0.00%> (-5.97%)` | :arrow_down: |
| [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/337/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `44.84% <0.00%> (-1.82%)` | :arrow_down: |
| [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/337/diff?src=pr&el=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/337?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/337?src=pr&el=footer). Last update [c6e7180...d4ddc85](https://codecov.io/gh/apache/apisix-ingress-controller/pull/337?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org