You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/23 03:21:00 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34687: [SPARK-36231][PYTHON] Support arithmetic operations of decimal(nan) series
HyukjinKwon commented on a change in pull request #34687:
URL: https://github.com/apache/spark/pull/34687#discussion_r754779946
##########
File path: python/pyspark/pandas/tests/data_type_ops/testing_utils.py
##########
@@ -49,8 +49,15 @@ def numeric_pdf(self):
dtypes = [np.int32, int, np.float32, float]
sers = [pd.Series([1, 2, 3], dtype=dtype) for dtype in dtypes]
sers.append(pd.Series([decimal.Decimal(1), decimal.Decimal(2), decimal.Decimal(3)]))
+ sers.append(pd.Series([1, 2, np.nan], dtype=float))
pdf = pd.concat(sers, axis=1)
- pdf.columns = [dtype.__name__ for dtype in dtypes] + ["decimal"]
+ pdf.columns = [dtype.__name__ for dtype in dtypes] + [
+ "decimal",
+ "float_nan",
+ ]
+ if LooseVersion(pd.__version__) >= LooseVersion("1.3.0"):
Review comment:
Just to clarify, old versions of pandas fails same with/without this PR, right? Supporting it only w/ 1.3.0 is okay as it's not a regression at least.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org