You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/26 04:41:58 UTC

[GitHub] [pulsar] 315157973 commented on a change in pull request #13950: [ServerCnx] Improve error logging for topic not found

315157973 commented on a change in pull request #13950:
URL: https://github.com/apache/pulsar/pull/13950#discussion_r792309353



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -1273,12 +1273,13 @@ protected void handleProducer(final CommandProducer cmdProducer) {
                     return null;
                 }
 
+                // Do not print stack traces for expected exceptions
                 if (cause instanceof NoSuchElementException) {
                     cause = new TopicNotFoundException("Topic Not Found.");
-                }
-                if (!Exceptions.areExceptionsPresentInChain(cause,
+                    log.error("[{}] Failed to load topic {}, producerId={}: Topic not found", remoteAddress, topicName,

Review comment:
       Since it is an exception that can be ignored, can we use info?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org