You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/13 08:42:39 UTC
[GitHub] [kafka] dongjinleekr opened a new pull request #9421: MINOR: Change deprecated 'scala.collection.JavaConverters' to 'scala.jdk.CollectionConverters'
dongjinleekr opened a new pull request #9421:
URL: https://github.com/apache/kafka/pull/9421
... with fixing typo, removing redundant method parameters, unused Throwables, and unused test methods.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dongjinleekr commented on pull request #9421: MINOR: Change deprecated 'scala.collection.JavaConverters' to 'scala.jdk.CollectionConverters'
Posted by GitBox <gi...@apache.org>.
dongjinleekr commented on pull request #9421:
URL: https://github.com/apache/kafka/pull/9421#issuecomment-712678668
Hi @chia7712,
I separated the other commits into this PR: https://github.com/apache/kafka/pull/9457
+1. Congratulations on becoming a committer. :smile:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9421: MINOR: Change deprecated 'scala.collection.JavaConverters' to 'scala.jdk.CollectionConverters'
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9421:
URL: https://github.com/apache/kafka/pull/9421#issuecomment-711617218
@dongjinleekr Thanks for your effort. nit: It would be better to avoid changing unrelated code in order to make this patch small but tough :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dongjinleekr commented on pull request #9421: MINOR: Change deprecated 'scala.collection.JavaConverters' to 'scala.jdk.CollectionConverters'
Posted by GitBox <gi...@apache.org>.
dongjinleekr commented on pull request #9421:
URL: https://github.com/apache/kafka/pull/9421#issuecomment-711610974
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dongjinleekr closed pull request #9421: MINOR: Change deprecated 'scala.collection.JavaConverters' to 'scala.jdk.CollectionConverters'
Posted by GitBox <gi...@apache.org>.
dongjinleekr closed pull request #9421:
URL: https://github.com/apache/kafka/pull/9421
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dongjinleekr commented on pull request #9421: MINOR: Change deprecated 'scala.collection.JavaConverters' to 'scala.jdk.CollectionConverters'
Posted by GitBox <gi...@apache.org>.
dongjinleekr commented on pull request #9421:
URL: https://github.com/apache/kafka/pull/9421#issuecomment-712109230
@chia7712 Great. I will separate the other commits into independent PR to make the commit clear. Stay tuned! :smile:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #9421: MINOR: Change deprecated 'scala.collection.JavaConverters' to 'scala.jdk.CollectionConverters'
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9421:
URL: https://github.com/apache/kafka/pull/9421#issuecomment-712893208
I don't think this PR will work with Scala 2.12. See https://github.com/scala/scala-collection-compat/issues/346
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dongjinleekr commented on pull request #9421: MINOR: Change deprecated 'scala.collection.JavaConverters' to 'scala.jdk.CollectionConverters'
Posted by GitBox <gi...@apache.org>.
dongjinleekr commented on pull request #9421:
URL: https://github.com/apache/kafka/pull/9421#issuecomment-777437606
Closing for it won't work with Scala 2.12.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org