You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by Michael Jakl <ja...@gmail.com> on 2009/08/15 20:00:14 UTC
[vysper] Commit of rev802821
Hi!
Since the change of rev802821 (null instead of empty string for
namespaces) I'm getting NullPointer Exceptions for my testcases
(coming from Render.java), they are not specific to my code (as far as
I can see) but don't come up with the test-cases of vysper-core.
Why is it better to return a null? If a XML element has no namespace
declared, it lies in the "empty" namespace, so a empty string would
conform to the standard.
If there is no particular need for the change, I'd rather revert it.
Thanks,
Michael
Re: [vysper] Commit of rev802821
Posted by Michael Jakl <ja...@gmail.com>.
Hi!
On Sun, Aug 16, 2009 at 08:35, Niklas Gustavsson<ni...@protocol7.com> wrote:
> On Sun, Aug 16, 2009 at 8:31 AM, Niklas Gustavsson<ni...@protocol7.com> wrote:
>>> Why is it better to return a null? If a XML element has no namespace
>>> declared, it lies in the "empty" namespace, so a empty string would
>>> conform to the standard.
>>
>> Right, please revert the change.
>
> I fixed it right away.
Thanks! I didn't do it yesterday because MUC was expecting nulls and I
had enough work to do ;)
Michael
Re: [vysper] Commit of rev802821
Posted by Niklas Gustavsson <ni...@protocol7.com>.
On Sun, Aug 16, 2009 at 8:31 AM, Niklas Gustavsson<ni...@protocol7.com> wrote:
>> Why is it better to return a null? If a XML element has no namespace
>> declared, it lies in the "empty" namespace, so a empty string would
>> conform to the standard.
>
> Right, please revert the change.
I fixed it right away.
/niklas
Re: [vysper] Commit of rev802821
Posted by Niklas Gustavsson <ni...@protocol7.com>.
On Sat, Aug 15, 2009 at 8:00 PM, Michael Jakl<ja...@gmail.com> wrote:
> Since the change of rev802821 (null instead of empty string for
> namespaces) I'm getting NullPointer Exceptions for my testcases
> (coming from Render.java), they are not specific to my code (as far as
> I can see) but don't come up with the test-cases of vysper-core.
Sorry about that, I failed to run the test cases in the pubsub module
before committing.
> Why is it better to return a null? If a XML element has no namespace
> declared, it lies in the "empty" namespace, so a empty string would
> conform to the standard.
Right, please revert the change.
/niklas