You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/01/01 00:00:06 UTC

[jira] [Commented] (DRILL-7505) PCAP Plugin Fails on IPv6 Packets

    [ https://issues.apache.org/jira/browse/DRILL-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006262#comment-17006262 ] 

ASF GitHub Bot commented on DRILL-7505:
---------------------------------------

cgivre commented on pull request #1946: DRILL-7505: PCAP Plugin Fails on IPv6 Packets
URL: https://github.com/apache/drill/pull/1946
 
 
   In its current implementation, the PCAP parser fails with an exception if it encounters a protocol it does not have in its enumerated list. 
   This is not an acceptable strategy in that there are many protocols out there and having Drill crash when it encounters an unknown protocol is not helpful or useful.  This minor PR makes the PCAP plugin more fault tolerant.
   
   I tested this on proprietary PCAP files which are too large to include.  Existing unit tests are unaffected.
   
   Jira: [Drill-7505](https://issues.apache.org/jira/browse/DRILL-7505)
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> PCAP Plugin Fails on IPv6 Packets
> ---------------------------------
>
>                 Key: DRILL-7505
>                 URL: https://issues.apache.org/jira/browse/DRILL-7505
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.17.0
>            Reporter: Charles Givre
>            Assignee: Charles Givre
>            Priority: Major
>             Fix For: 1.18.0
>
>
> In its current implementation, the PCAP parser fails with an exception if it encounters a protocol it does not have in its enumerated list. 
> This is not an acceptable strategy in that there are many protocols out there and having Drill crash when it encounters an unknown protocol is not helpful or useful.  This minor PR makes the PCAP plugin more fault tolerant.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)