You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/05/17 14:03:53 UTC

[GitHub] wujimin commented on a change in pull request #713: [SCB-591] configcenter need to do encode

wujimin commented on a change in pull request #713:  [SCB-591] configcenter need to do encode
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/713#discussion_r188969579
 
 

 ##########
 File path: dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
 ##########
 @@ -329,8 +329,14 @@ private void sendHeartbeat(WebSocket ws) {
 
     public void refreshConfig(String configcenter, boolean wait) {
       CountDownLatch latch = new CountDownLatch(1);
+      String encodeServiceName = "";
+      try {
+        encodeServiceName = URLEncoder.encode(serviceName, "UTF-8");
+      } catch (UnsupportedEncodingException e1) {
+        e1.printStackTrace();
 
 Review comment:
   print?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services