[jira] [Commented] (HBASE-5737) Minor Improvements related to balancer.

["Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250870#comment-13250870 ] 

Zhihong Yu commented on HBASE-5737:
-----------------------------------

For AssignmentManager.setBalancer(), there is whitespace in javadoc.
'balancer to set' should be on the same line as @param line.

w.r.t. introducing TreeMap, I would prefer to see the benefit in a real world scenario. I think HashMap serves us well currently.
                
> Minor Improvements related to balancer.
> ---------------------------------------
>
>                 Key: HBASE-5737
>                 URL: https://issues.apache.org/jira/browse/HBASE-5737
>             Project: HBase
>          Issue Type: Improvement
>          Components: master
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>         Attachments: HBASE-5737.patch
>
>
> Currently in Am.getAssignmentByTable()  we use a result map which is currenly a hashmap.  It could be better if we have a treeMap.  Even in MetaReader.fullScan we have the treeMap only so that we have the naming order maintained. I felt this change could be very useful in cases where we are extending the DefaultLoadBalancer.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira