You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Anthony Baker <ab...@apache.org> on 2017/01/20 19:56:51 UTC
Re: Review Request 54586: GEODE-2172:
CustomConfigWithCacheIntegrationTest
fails with AssertionError on Windows
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54586/#review162488
-----------------------------------------------------------
Ship it!
Ship It!
- Anthony Baker
On Dec. 19, 2016, 12:45 p.m., Kai Jiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54586/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2016, 12:45 p.m.)
>
>
> Review request for geode, Jinmei Liao, Kirk Lund, and Dan Smith.
>
>
> Bugs: geode-2172
> https://issues.apache.org/jira/browse/geode-2172
>
>
> Repository: geode
>
>
> Description
> -------
>
> cacheLogWriterMessageShouldMatchCustomConfig fails with AssertionError.
>
> The issues is related to incorrect regex pattern. The regex pattern used to match log string contains newline character. To fix this issue, I've replaced Unix newline character in regex pattern into `System.lineSeparator()`, a Platform-dependent newline character in Java.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/org/apache/geode/internal/logging/log4j/custom/CustomConfiguration.java 47515e6
>
> Diff: https://reviews.apache.org/r/54586/diff/
>
>
> Testing
> -------
>
> I've run this unit test both on Windows and MacOS. And it passes.
>
>
> Thanks,
>
> Kai Jiang
>
>