You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zhangminglei <gi...@git.apache.org> on 2018/02/09 12:04:58 UTC
[GitHub] flink pull request #5440: [FLINK-6160] [flip-6] Retry JobManager/ResourceMan...
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/5440
[FLINK-6160] [flip-6] Retry JobManager/ResourceManager connection in …
## What is the purpose of the change
When timeout comes, retry JobManager/ResourceManager connection in case of timeout
## Brief change log
When timeout, invoke ```requestHeartbeat``` in HeartbeatMonitor thread. Not directly invoke ```notifyHeartbeatTimeout``` and close the connection.
## Verifying this change
This change is already covered by existing tests, but did minor changes. in the TaskExecutorTest.java, change ```testHeartbeatTimeoutWithResourceManager``` behavior to while timeout, does not invoke ```disconnectTaskManager```.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): ( don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no )
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-6160
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5440.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5440
----
commit 5319abdf503c757baf7afde9913ab2fb6fb61b60
Author: zhangminglei <zm...@...>
Date: 2018-02-09T11:52:50Z
[FLINK-6160] [flip-6] Retry JobManager/ResourceManager connection in case of timeout
----
---
[GitHub] flink issue #5440: [FLINK-6160] [flip-6] Retry JobManager/ResourceManager co...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5440
@tillrohrmann Could you please take a look on this when available ? Thanks
---
[GitHub] flink pull request #5440: [FLINK-6160] [flip-6] Retry JobManager/ResourceMan...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei closed the pull request at:
https://github.com/apache/flink/pull/5440
---