You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/11 15:48:42 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #18890: Fix failing static check

kaxil commented on a change in pull request #18890:
URL: https://github.com/apache/airflow/pull/18890#discussion_r726243434



##########
File path: airflow/www/security.py
##########
@@ -553,7 +553,7 @@ def clean_perms(self):
         perms = sesh.query(sqla_models.PermissionView).filter(
             or_(
                 sqla_models.PermissionView.permission == None,  # noqa
-                sqla_models.PermissionView.view_menu == None,
+                sqla_models.PermissionView.view_menu == None,  # flake8: noqa

Review comment:
       Just `# noqa` does not work as it fight with our `https://github.com/asottile/yesqa` pre-commit

##########
File path: airflow/www/security.py
##########
@@ -553,7 +553,7 @@ def clean_perms(self):
         perms = sesh.query(sqla_models.PermissionView).filter(
             or_(
                 sqla_models.PermissionView.permission == None,  # noqa
-                sqla_models.PermissionView.view_menu == None,
+                sqla_models.PermissionView.view_menu == None,  # flake8: noqa

Review comment:
       Just `# noqa` does not work as it fights with our `https://github.com/asottile/yesqa` pre-commit




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org