You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "dougdonohoe (via GitHub)" <gi...@apache.org> on 2024/11/07 12:37:57 UTC
Re: [PR] WICKET-6794 Performance improvements for UrlEncoder and UrlDecoder [wicket]
dougdonohoe commented on code in PR #436:
URL: https://github.com/apache/wicket/pull/436#discussion_r1832612129
##########
wicket-util/src/main/java/org/apache/wicket/util/encoding/UrlDecoder.java:
##########
@@ -16,25 +16,24 @@
*/
package org.apache.wicket.util.encoding;
+import java.io.ByteArrayOutputStream;
import java.io.UnsupportedEncodingException;
import java.nio.charset.Charset;
import java.nio.charset.IllegalCharsetNameException;
import java.nio.charset.UnsupportedCharsetException;
import org.apache.wicket.util.lang.Args;
-import org.apache.wicket.util.string.Strings;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
- * Adapted from java.net.URLDecoder, but defines instances for query string decoding versus URL path
+ * Adapted from Spring Framework's UriUtils class, but defines instances for query string decoding versus URL path
* component decoding.
* <p/>
* The difference is important because a space is encoded as a + in a query string, but this is a
* valid value in a path component (and is therefore not decode back to a space).
- *
- * @author Doug Donohoe
- * @see java.net.URLDecoder
+ *
+ * @author Thomas Heigl
Review Comment:
I happened to be looking at Wicket source code again and noticed this change. I'm the original author of the UrlDecode, originating back in 2008 in https://issues.apache.org/jira/browse/WICKET-1627.
This @author change is not cool. It should at least be:
```
@author Doug Donohoe
@author Thomas Heigl
```
CC: @theigl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org