You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/17 01:23:13 UTC
[GitHub] [arrow] GregBowyer opened a new pull request #8948: ARROW-10943: WIP: HACK! Test bool miri bugs
GregBowyer opened a new pull request #8948:
URL: https://github.com/apache/arrow/pull/8948
@alamb @andygrove
No idea if this is the root cause, but I figured that if its reading an incorrect number as a boolean its a messy transmute or similar.
As such I ran miri over the specific failing test and got two hits, one on the hash function and one on the bit packing.
The first commit states that the bit packing is unaligned which I think is ok to take (although it might be worth revisiting the bit-packing code).
The second replaces the hash function which is stated as being unaligned. I dont know if wyhash is the perfect choice (xxHash, t1ha or others might be equally good choices) but it does not suffer from irritating miri.
Thoughts? Ideas?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8948: ARROW-10943: WIP: HACK! Test bool miri bugs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8948:
URL: https://github.com/apache/arrow/pull/8948#issuecomment-747146364
https://issues.apache.org/jira/browse/ARROW-10943
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #8948: ARROW-10943: WIP: HACK! Test bool miri bugs
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #8948:
URL: https://github.com/apache/arrow/pull/8948#issuecomment-747777805
Thanks @GregBowyer - this is great. I plan to review this / do some more careful testing later this week or the weekend
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #8948: ARROW-10943: WIP: HACK! Test bool miri bugs
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #8948:
URL: https://github.com/apache/arrow/pull/8948#issuecomment-748528180
I found that by running the parquet tests in a loop I can reproduce the failure on my machine locally [more details in JIRA](https://issues.apache.org/jira/browse/ARROW-10943?focusedCommentId=17252273&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17252273).
Unfortunately, when I tried running the same experiment on this branch the test still fails intermittently
```
---- encodings::encoding::tests::test_bool stdout ----
thread 'encodings::encoding::tests::test_bool' panicked at 'Invalid byte when reading bool', parquet/src/util/bit_util.rs:73:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] GregBowyer closed pull request #8948: ARROW-10943: WIP: HACK! Test bool miri bugs
Posted by GitBox <gi...@apache.org>.
GregBowyer closed pull request #8948:
URL: https://github.com/apache/arrow/pull/8948
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] GregBowyer commented on pull request #8948: ARROW-10943: WIP: HACK! Test bool miri bugs
Posted by GitBox <gi...@apache.org>.
GregBowyer commented on pull request #8948:
URL: https://github.com/apache/arrow/pull/8948#issuecomment-749894660
This appears not to be the issue, we might want miri at some point but not his.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org