You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/07 14:39:55 UTC
[GitHub] [airflow] ivarec opened a new pull request, #28780: Fix hot loop with a burst of log messages (#28778)
ivarec opened a new pull request, #28780:
URL: https://github.com/apache/airflow/pull/28780
closes: #28778
Fixes a very small issue where a hot loop in the clean-logs.sh script could cause a burst of a few hundred log messages without need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ivarec commented on pull request #28780: Fix hot loop with a burst of log messages (#28778)
Posted by GitBox <gi...@apache.org>.
ivarec commented on PR #28780:
URL: https://github.com/apache/airflow/pull/28780#issuecomment-1377345625
@potiuk sorry for mentioning you if this is not correct, but you are my sole contact so far :smile_cat:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #28780: Fix hot loop with a burst of log messages (#28778)
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #28780:
URL: https://github.com/apache/airflow/pull/28780#issuecomment-1378377555
Please fix the pre-commit issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ivarec commented on pull request #28780: Fix hot loop with a burst of log messages (#28778)
Posted by GitBox <gi...@apache.org>.
ivarec commented on PR #28780:
URL: https://github.com/apache/airflow/pull/28780#issuecomment-1377344627
Hmm about the failed test: I probably missed a step where this Dockerfile gets created from the modified script. Can someone more knowledgeable help with this? First time contributor here :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #28780: Fix hot loop with a burst of log messages (#28778)
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #28780:
URL: https://github.com/apache/airflow/pull/28780#issuecomment-1378620808
@ivarec `pip install pre-commit && pre-commit run` should do it hopefully.
There are more detailed instructions on https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#id3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28780: Fix hot loop with a burst of log messages (#28778)
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #28780:
URL: https://github.com/apache/airflow/pull/28780#issuecomment-1384335195
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28780: Fix hot loop with a burst of log messages (#28778)
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28780:
URL: https://github.com/apache/airflow/pull/28780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28780: Fix hot loop with a burst of log messages (#28778)
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #28780:
URL: https://github.com/apache/airflow/pull/28780#issuecomment-1374501935
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org