[jira] [Comment Edited] (WICKET-6465) PageStore not cleared at session end

["Andrea Del Bene (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160330#comment-16160330 ] 

Andrea Del Bene edited comment on WICKET-6465 at 9/10/17 3:05 PM:
------------------------------------------------------------------

Hi,

I've noticed something interesting in method Session#destroy that might be part of the problem. As its JavaDoc states the method was meant to dispose  session store and page manager when session is invalidated. At the moment there's no code for page manager, it was removed in (massive) commit 4977f66. I would expect that when this method is invoked it calls IPageManager#clear (implemented by PageStoreManager). In this way we could get rid of the updating flag and its logic. 

I've attached a patch showing my fix


was (Author: bitstorm):
Hi,

I've noticed something interesting in method Session#destroy that might be part of the problem. As its JavaDoc states the method was meant to dispose  session store and page manager when session is invalidated. At the moment there's no code for page manager, it was removed in (massive) commit 4977f66. I would expect that when this method is invoked it calls IPageManager#clear (implemented by PageStoreManager). In this way we could get rid of the updating flag and its logic. 

> PageStore not cleared at session end
> ------------------------------------
>
>                 Key: WICKET-6465
>                 URL: https://issues.apache.org/jira/browse/WICKET-6465
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 7.8.0
>         Environment: Tomcat
>            Reporter: Franta Mejta
>            Assignee: Emond Papegaaij
>            Priority: Critical
>         Attachments: WICKET-6465.patch
>
>
> WICKET-6387 causes the page store not to be cleared at logout on Tomcat. The problem is that tomcat does not call {{valueUnbound}} or {{valueBound}} when an attribute is set to the current value (new == old).
> https://github.com/apache/tomcat/blob/e28b35c9e40aeb4b7ac52a98f07ad965630e2766/java/org/apache/catalina/session/StandardSession.java#L1424



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)