You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "2010YOUY01 (via GitHub)" <gi...@apache.org> on 2023/05/26 18:35:44 UTC

[GitHub] [arrow-datafusion] 2010YOUY01 commented on pull request #6462: Improve `BuiltInFunction` Name Lookup

2010YOUY01 commented on PR #6462:
URL: https://github.com/apache/arrow-datafusion/pull/6462#issuecomment-1564779391

   I forget to mention in the original PR https://github.com/apache/arrow-datafusion/pull/6448 : the rationale behind storing the mapping (`ALL_FUNCTIONS`) separately is for future implementation of 'Did you mean': `select powr() -> Error: Did you mean power()?`, otherwise copy and paste the mapping in `FromStr` into `Display` would be okay.
   
   Also I thought iterating through a small vector several times is not likely to be the performance issue for an analytical system, so the original implementation is trying to make the code more maintainable and avoid over-engineering.
   But this speedup implementation is very effective and clean, thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org