You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by mm...@apache.org on 2008/01/15 11:25:34 UTC
svn commit: r612071 -
/spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/DKIM.pm
Author: mmartinec
Date: Tue Jan 15 02:25:32 2008
New Revision: 612071
URL: http://svn.apache.org/viewvc?rev=612071&view=rev
Log:
DKIM: avoid a "Use of uninitialized value" warning when a From header field is missing in a message, Bug 5786
Modified:
spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/DKIM.pm
Modified: spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/DKIM.pm
URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/DKIM.pm?rev=612071&r1=612070&r2=612071&view=diff
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/DKIM.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/DKIM.pm Tue Jan 15 02:25:32 2008
@@ -334,7 +334,8 @@
$verifier->CLOSE(); # the action happens here
my $author = $verifier->message_originator;
- $author = !$author ? '' : $author->address();
+ $author = $author->address() if $author;
+ $author = '' if !defined $author; # when a From header field is missing
# Mail::DKIM sometimes leaves leading or trailing whitespace in address
$author =~ s/^[ \t]+//s; $author =~ s/[ \t]+\z//s; # trim
if ($author ne $scan->{dkim_author_address}) {