You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by witgo <gi...@git.apache.org> on 2014/06/02 16:49:27 UTC
[GitHub] spark pull request: update breeze to version 0.8.1
GitHub user witgo opened a pull request:
https://github.com/apache/spark/pull/940
update breeze to version 0.8.1
`breeze 0.8.1` dependent on `scala-logging-slf4j 2.1.1` The relevant code on #332
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/witgo/spark breeze-8.0.1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/940.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #940
----
commit 2f77d52fc326498bcb7774462a9a7b370fd7250e
Author: witgo <wi...@qq.com>
Date: 2014-06-02T14:43:42Z
update breeze to version 0.8.1
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50851243
That sounds good to me but I'm not familiar with the tasks related to Scala 2.11. Please run the discussion on https://issues.apache.org/jira/browse/SPARK-1812
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by dlwh <gi...@git.apache.org>.
Github user dlwh commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50310077
"Release Plans" implies that there is a plan. :-). My general policy is to cut a release whenever someone asks (or within a couple of weeks of that). We've done a bunch of refactoring to the algebraic hierarchy and a few other biggish things, so I might be a bit more cautious than usual. There are also some features I'd like to see in a 0.9 that will take some time, but if you need a release I can cause one to appear.
quasiquotes is a compile time thing and you can probably exclude it from your dependencies without a problem. I'm not quite sure how they got in there.
For Commons Math: We mostly use the LP solver, some numerics routines, random number generation, and some probability distributions. Happy to accept a PR that maintains the same level of functionality with whatever version of commons math.
```
fukaeri:breeze dlwh (master)$ grep -R "math3" math/src/
math/src//main/scala/breeze/numerics/package.scala:import org.apache.commons.math3.special.{Gamma => G, Erf}
math/src//main/scala/breeze/numerics/package.scala:import org.apache.commons.math3.util.FastMath
math/src//main/scala/breeze/numerics/package.scala: * @see http://commons.apache.org/proper/commons-math/apidocs/org/apache/commons/math3/special/Gamma.html#regularizedGammaP(double, double)
math/src//main/scala/breeze/numerics/package.scala: * @see http://commons.apache.org/proper/commons-math/apidocs/org/apache/commons/math3/special/Gamma.html#regularizedGammaP(double, double)
math/src//main/scala/breeze/optimize/FirstOrderMinimizer.scala:import org.apache.commons.math3.random.MersenneTwister
math/src//main/scala/breeze/optimize/linear/LinearProgram.scala:import org.apache.commons.math3.optim.linear._
math/src//main/scala/breeze/optimize/linear/LinearProgram.scala:import org.apache.commons.math3.optim.nonlinear.scalar._
math/src//main/scala/breeze/stats/distributions/ApacheDistributionWrapper.scala:import org.apache.commons.math3.distribution.{FDistribution => ApacheFDistribution, AbstractRealDistribution => ApacheRealDistribution, AbstractIntegerDistribution => ApacheIntegerDistribution}
math/src//main/scala/breeze/stats/distributions/CauchyDistribution.scala:import org.apache.commons.math3.distribution.{CauchyDistribution => ApacheCauchyDistribution}
math/src//main/scala/breeze/stats/distributions/FDistribution.scala:import org.apache.commons.math3.distribution.{FDistribution => ApacheFDistribution, RealDistribution => ApacheRealDistribution}
math/src//main/scala/breeze/stats/distributions/HypergeometricDistribution.scala:import org.apache.commons.math3.distribution.{HypergeometricDistribution => ApacheHypergeometricDistribution}
math/src//main/scala/breeze/stats/distributions/LevyDistribution.scala:import org.apache.commons.math3.distribution.{LevyDistribution => ApacheLevyDistribution}
math/src//main/scala/breeze/stats/distributions/LevyDistribution.scala:import org.apache.commons.math3.random.{RandomGenerator, JDKRandomGenerator}
math/src//main/scala/breeze/stats/distributions/Rand.scala:import org.apache.commons.math3.random.{MersenneTwister, RandomGenerator}
math/src//main/scala/breeze/stats/distributions/StudentsT.scala:import org.apache.commons.math3.distribution.TDistribution
math/src//main/scala/breeze/stats/distributions/ThreadLocalRandomGenerator.scala:import org.apache.commons.math3.random.RandomGenerator
math/src//main/scala/breeze/stats/distributions/TriangularDistribution.scala:import org.apache.commons.math3.distribution.{TriangularDistribution => ApacheTriangularDistribution}
math/src//main/scala/breeze/stats/distributions/VariableKernelEmpiricalDistribution.scala:import org.apache.commons.math3.random.{EmpiricalDistribution => ApacheEmpiricalDistribution}
math/src//main/scala/breeze/stats/distributions/WeibullDistribution.scala:import org.apache.commons.math3.distribution.{WeibullDistribution => ApacheWeibullDistribution}
math/src//main/scala/breeze/stats/distributions/ZipfDistribution.scala:import org.apache.commons.math3.distribution.{ZipfDistribution => ApacheZipfDistribution}
math/src//test/scala/breeze/stats/distributions/ChiSquaredTest.scala:import org.apache.commons.math3.random.MersenneTwister
math/src//test/scala/breeze/stats/distributions/GammaTest.scala:import org.apache.commons.math3.random.MersenneTwister
math/src//test/scala/breeze/stats/distributions/GeometricTest.scala:import org.apache.commons.math3.random.MersenneTwister
math/src//test/scala/breeze/stats/distributions/GumbelTest.scala:import org.apache.commons.math3.random.MersenneTwister
math/src//test/scala/breeze/stats/distributions/LaplaceTest.scala:import org.apache.commons.math3.random.MersenneTwister
math/src//test/scala/breeze/stats/distributions/LogarthmicTest.scala:import org.apache.commons.math3.random.MersenneTwister
math/src//test/scala/breeze/stats/distributions/ParetoTest.scala:import org.apache.commons.math3.random.MersenneTwister
math/src//test/scala/breeze/stats/distributions/RayleighTest.scala:import org.apache.commons.math3.random.MersenneTwister
math/src//test/scala/breeze/stats/distributions/StudentsTTest.scala:import org.apache.commons.math3.random.MersenneTwister
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by markhamstra <gi...@git.apache.org>.
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-44914945
Neither does spark 1.0.0.
We've offered no guarantee that any spark 1.x will work with scala 2.11. If it turns out that we can't cross-compile for scala 2.10 and 2.11 with essentially the same source code and dependencies and preserving our intention to preserve binary compatibility, then that may be the occasion that forces the beginning of spark 2.0 development.
In any event, the breaking of our intent to preserve binary compatibility is no small matter and shouldn't slip into a PR without considerable discussion. I'm not certain that that is what is happening with this PR, but I do think that it is critical that we understand how strong our checks for binary compatibility are and what are the bounds on dependency upgrades that we can make while preserving that compatibility.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by witgo <gi...@git.apache.org>.
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50906124
How do we resolve this issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by avati <gi...@git.apache.org>.
Github user avati commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50894442
@mengxr Based on the dependency graph, I am guessing we will now have jar hell problem with scalalogging-slf4j 2.1.2 (needed by breeze 0.8.1) vs 1.0.1 (used by sql/). Breeze 0.7 was depending on 0.7 too. But 2.1.2 and 1.0.1 are not compatible.
So #1701 (or equivalent) needs to be merged soon to resolve the issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50855852
QA tests have started for PR 940. This patch merges cleanly. <br>View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17660/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [WIP] update breeze to version 0.8.1
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-44862969
All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15350/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [WIP] update breeze to version 0.8.1
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-44858187
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50860395
QA tests have started for PR 940. This patch merges cleanly. <br>View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17666/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by avati <gi...@git.apache.org>.
Github user avati commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50897230
Yes, either #1701 or #1369. We are already broken till they are committed.
On Fri, Aug 1, 2014 at 8:19 AM, Xiangrui Meng <no...@github.com>
wrote:
> Ah, I see. Tests were against individual build instead of the assembly
> jar. We should have integration tests in the future.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/940#issuecomment-50896710>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50896659
Is that a problem? just update `sql/catalyst` to use 2.1.2? Do we know if that would be any problem? @witgo has a PR to standardize use of scalalogging-slf4j anyway (https://github.com/apache/spark/pull/1369) which bumps to 2.1.2 and seems to have worked. Maybe that should go in with this to ensure all is compatible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-49508061
QA tests have started for PR 940. This patch merges cleanly. <br>View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16848/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50303013
@witgo Thanks for checking the dependencies on the JIRA page! I list the dependency graph here so other people can see the difference easily. I think we need to figure out the following:
* Which part of breeze needs commons-math3? The problem with commons-math3 is that hadoop 2.3 and 2.4 depend on commons-math3-3.1.1, which is not fully compatible with 3.2.
@dlwh Could you help answer this and what is the plan for the 0.9 release? I saw you updated the version to `0.9-SNAPSHOT`.
* Is `org.scalamacros:quasiquotes` a problem? @marmbrus
breeze-0.7
~~~
+-org.scalanlp:breeze_2.10:0.7 [S]
+-com.github.fommil.netlib:core:1.1.2
+-com.github.rwl:jtransforms:2.4.0
| +-junit:junit:4.8.2
|
+-com.thoughtworks.paranamer:paranamer:2.2
+-com.typesafe:scalalogging-slf4j_2.10:1.0.1
| |
| +-org.slf4j:slf4j-api:1.7.2
|
+-net.sf.opencsv:opencsv:2.3
+-net.sourceforge.f2j:arpack_combined_all:0.1
+-org.apache.commons:commons-math3:3.2
+-org.scalanlp:breeze-macros_2.10:0.3 [S]
|
+-org.spire-math:spire_2.10:0.7.1 [S]
|
+-org.spire-math:spire-macros_2.10:0.7.1 [S]
~~~
breeze-0.8.1
~~~
+-org.scalanlp:breeze_2.10:0.8.1 [S]
+-com.github.fommil.netlib:core:1.1.2
+-com.github.rwl:jtransforms:2.4.0
| +-junit:junit:4.8.2
|
+-com.typesafe.scala-logging:scala-logging-slf4j_2.10:2.1.2 [S]
| |
| +-com.typesafe.scala-logging:scala-logging-api_2.10:2.1.2 [S]
| |
| +-org.slf4j:slf4j-api:1.7.7
|
+-net.sf.opencsv:opencsv:2.3
+-net.sourceforge.f2j:arpack_combined_all:0.1
+-org.apache.commons:commons-math3:3.2
+-org.scalanlp:breeze-macros_2.10:0.3.1 [S]
| |
| +-org.scalamacros:quasiquotes_2.10:2.0.0 [S]
|
+-org.spire-math:spire_2.10:0.7.4 [S]
|
+-org.scalamacros:quasiquotes_2.10:2.0.0 [S]
|
+-org.spire-math:spire-macros_2.10:0.7.4 [S]
+-org.scalamacros:quasiquotes_2.10:2.0.0 [S]
~~~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [WIP][SPARK-1997] update breeze to version 0.8...
Posted by witgo <gi...@git.apache.org>.
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-44965251
I think ,`breeze` no big change from `0.7` to `0.8.1`. Of course, this conclusion has not been a lot of testing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by avati <gi...@git.apache.org>.
Github user avati commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50910905
> I reverted the change in #1718 <https://github.com/apache/spark/pull/1718>
> and asked @marmbrus <https://github.com/marmbrus> to take look at the
> dependency issues caused by scala-logging.
>
The other option could have been to keep #940 merged and merge also #1701
(if #1369 is too invasive/requires more review), that combination seems to
work at least for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by avati <gi...@git.apache.org>.
Github user avati commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50899294
> I think Jenkins should be fine but the assembly jar is broken. Is it right?
>
I think so, just like commons-math3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50854138
@witgo Could you update the pom to exclude `commons-math3` from dependencies? I tried at local and LBFGS works well. It should be safe to remove `commons-math3`. For scalamacros, catalyst also depends on it. My diff is at:
https://github.com/mengxr/spark/compare/apache:master...mengxr:breeze-deps?expand=1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by avati <gi...@git.apache.org>.
Github user avati commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50850441
> Yes, it is already a problem with breeze 0.7. But we didn't realized that
> hadoop 2.3 depends on commons-math3 in the Spark v1.0 release. If there is
> a way to avoid including commons-math3, we should do that.
>
I think that sounds like an orthogonal problem to 0.7 vs 0.8.1. Upgrading
to 0.8.1 will help long way towards Scala 2.11 porting, without worsening
the commons-math3 issue. Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by witgo <gi...@git.apache.org>.
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50860276
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [WIP] update breeze to version 0.8.1
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-44886830
I don't think we ever expose Breeze in public facing API, do we?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50897829
I think Jenkins should be fine but the assembly jar is broken. Is it right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by witgo <gi...@git.apache.org>.
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50297230
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50369429
David is right that quasiquotes are just a compile time dependency and are not needed at runtime. Also, we will be pulling them in for codegen in Spark SQL, so there is probably no harm just ignoring them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-49578863
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-48688769
QA tests have started for PR 940. This patch merges cleanly. <br>View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16545/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50291749
QA tests have started for PR 940. This patch DID NOT merge cleanly! <br>View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17265/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by nevillelyh <gi...@git.apache.org>.
Github user nevillelyh commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-46575215
@mengxr https://issues.apache.org/jira/browse/SPARK-2200
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50859290
QA results for PR 940:<br>- This patch FAILED unit tests.<br>- This patch merges cleanly<br>- This patch adds no public classes<br><br>For more information see test ouptut:<br>https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17660/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50908990
I reverted the change in #1718 and asked @marmbrus to take look at the dependency issues caused by scala-logging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50912477
I'm okay with upgrading the version of scala logging that we use as @avati suggests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50297424
QA tests have started for PR 940. This patch merges cleanly. <br>View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17271/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [WIP] update breeze to version 0.8.1
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-44862968
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [WIP] update breeze to version 0.8.1
Posted by markhamstra <gi...@git.apache.org>.
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-44861308
What is the reason for this change, and how does it affect our intention to maintain binary compatibility?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by witgo <gi...@git.apache.org>.
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50855187
@mengxr done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/940#discussion_r15684374
--- Diff: mllib/pom.xml ---
@@ -60,6 +60,14 @@
<groupId>junit</groupId>
<artifactId>junit</artifactId>
</exclusion>
+ <!-- <exclusion>
--- End diff --
Could you remove this commented block?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50850308
Yes, it is already a problem with breeze 0.7. But we didn't realized that hadoop 2.3 depends on commons-math3 in the Spark v1.0 release. If there is a way to avoid including commons-math3, we should do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [WIP][SPARK-1997] update breeze to version 0.8...
Posted by ktham <gi...@git.apache.org>.
Github user ktham commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-45161797
Just looked at the release notes for Breeze 0.8 and initial glance at the commits... is there any particular reason why we are holding back this PR? If we want to cross compile with Scala 2.11, then we have to upgrade to breeze 0.8 because there does not exist a 2.11 build of breeze 0.7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [WIP] update breeze to version 0.8.1
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-44852324
All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15348/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by avati <gi...@git.apache.org>.
Github user avati commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50850842
> But is it needed for the v1.1 release? Spark v1.1 doesn't support Scala
> 2.11.
>
Not, I guess. I din't realize Spark 1.1 was not yet release branched. I
will try to move Scala 2.11 related dependency changes into a separate
build profile then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-46529144
@nevillelyh Is there a JIRA for it? Is it fixed in 0.8.1?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50291855
@witgo Could you merge the latest master? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50850626
But is it needed for the v1.1 release? Spark v1.1 doesn't support Scala 2.11.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by witgo <gi...@git.apache.org>.
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-44911857
@markhamstra , `breeze 0.7 ` does not support `scala 2.11` .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: update breeze to version 0.8.1
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-44846798
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [WIP] update breeze to version 0.8.1
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-44858195
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50896710
Ah, I see. Tests were against individual build instead of the assembly jar. We should have integration tests in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [WIP][SPARK-1997] update breeze to version 0.8...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-45067069
Let's put this PR on hold until Spark moves to Scala 2.11. Good to see that the breeze functions we used did not change in breeze-0.8.1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: update breeze to version 0.8.1
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-44846769
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [WIP][SPARK-1997] update breeze to version 0.8...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-45180288
@ktham I think @markhamstra 's comments addressed the concerns very well. Unless there are critical bugs in breeze 0.7, we should wait until Spark core starts to move. Breeze has a fast release cycle. So we don't need to rush to 0.8.1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by witgo <gi...@git.apache.org>.
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/940#discussion_r15684437
--- Diff: mllib/pom.xml ---
@@ -60,6 +60,14 @@
<groupId>junit</groupId>
<artifactId>junit</artifactId>
</exclusion>
+ <!-- <exclusion>
--- End diff --
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [WIP] update breeze to version 0.8.1
Posted by markhamstra <gi...@git.apache.org>.
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-44889156
We shouldn't, so I think we maintain source compatibility without any trouble. Are the MIMA checks good enough to catch binary incompatibility when we make significant changes to library dependencies? Not that I am asserting that this Breeze change is particularly significant, since I haven't look at the diff from 0.7. I'm more interested in the general case of what needs to be checked or done when we want to update dependencies while staying within the bounds of 1.x.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50295014
QA results for PR 940:<br>- This patch FAILED unit tests.<br>- This patch merges cleanly<br>- This patch adds no public classes<br><br>For more information see test ouptut:<br>https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17268/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50293521
QA tests have started for PR 940. This patch merges cleanly. <br>View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17268/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/940
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50892988
LGTM. Merged into master. Note that Jenkins didn't tell the full story because we have `commons-math3` in the test scope. I built the assembly jar and verified LBFGS work. Please create a JIRA and ping me if you encounter problems with this change. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50909587
I think @witgo's PR strongly suggests it's OK to upgrade to 2.1.2?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by witgo <gi...@git.apache.org>.
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50293501
@mengxr Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-48693022
QA results for PR 940:<br>- This patch PASSES unit tests.<br>- This patch merges cleanly<br>- This patch adds no public classes<br><br>For more information see test ouptut:<br>https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16545/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by nevillelyh <gi...@git.apache.org>.
Github user nevillelyh commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-46521234
We just hit a bug when DenseVector in 0.7 triggers StackOverflowError in KryoSerializer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50299031
QA results for PR 940:<br>- This patch PASSES unit tests.<br>- This patch merges cleanly<br>- This patch adds no public classes<br><br>For more information see test ouptut:<br>https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17271/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50379548
@dlwh Thanks for the quick reply! The `commons-math3` problem is not which version to use but how to match the version hadoop depends on. We can switch to 3.1.1 to match hadoop 2.3/2.4 for now. But if hadoop upgrades to 3.2 or 3.3 in the future, we still have version conflicts unless we maintain a version mapping in our build or shade commons-math3. I tried to downgrade `commons-math3` to 3.1.1 in breeze and found two missing in 3.1.1: `Erf` and `LevyDistribution`.
mllib uses `LBFGS` from breeze, which depends on `FirstOrderMinimizer`. But it doesn't touch `RandBasis`. I'll check whether it is safe to exclude `commons-math3` in mllib. If it is, we should probably do that.
@marmbrus Thanks! Then it should be safe to exclude `quasiquotes`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50291675
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50864392
QA results for PR 940:<br>- This patch PASSES unit tests.<br>- This patch merges cleanly<br>- This patch adds no public classes<br><br>For more information see test ouptut:<br>https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17666/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1997] update breeze to version 0.8.1
Posted by avati <gi...@git.apache.org>.
Github user avati commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50849972
@mengxr looking at the dependency graphs of breeze 0.7 and 0.8.1, it appears that both the versions are depending on commons-math3:3.2. If hadoop 2.3 and 2.4 depend on commons-math3:3.1.1, then it is already a problem with breeze 0.7 itself, no? Am I overlooking something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [WIP] update breeze to version 0.8.1
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-44852322
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---