You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "pangwangshu (via GitHub)" <gi...@apache.org> on 2026/10/10 21:22:14 UTC
[PR] [Python] Optionally write chunk content to Qdrant payload [beam]
pangwangshu opened a new pull request, #40502:
URL: https://github.com/apache/beam/pull/40502
Adds an optional `content_payload_key` field to `QdrantWriteConfig`. When set, the converter stores `EmbeddableItem.content_string` under that key in the point payload, next to the metadata, so points retrieved from a collection written by Beam carry the chunk text. `BigQueryVectorWriterConfig` and the Milvus writer already persist the content; the Qdrant writer stored only `item.metadata`.
- The default is `None`, which writes only the metadata as before, so there is no behavior change for existing users.
- A key that collides with a metadata key raises `ValueError` instead of overwriting it.
- An empty key is rejected in `__post_init__`.
- The item's `metadata` dict is copied, not mutated.
- As with the BigQuery writer, an item with no text or image URI raises `ValueError` from `content_string` when the key is set.
The two design questions in #40476 are still open: whether leaving the content out was deliberate, and whether an opt-in key is the right shape compared with always writing to a fixed `"content"` key. I am happy to change the name or the default based on review.
**Testing**
- `qdrant_test.py`: 5 new converter tests (default unchanged, key writes content, no metadata, collision, empty key). All 43 tests in the file pass locally.
- `qdrant_it_test.py`: new `test_write_with_content_payload_key` writes through the transform to a testcontainers Qdrant instance and asserts the payload read back is the metadata plus the content. All 7 tests in the file pass locally on DirectRunner.
- `CHANGES.md` updated.
**AI assistance disclosure**
Per the [ASF generative tooling guidance](https://www.apache.org/legal/generative-tooling.html): this change was written with the help of Claude Code (Claude Opus 5.5). I have reviewed the code and tests and ran them locally, and to my knowledge the change contains no third-party copyrighted material.
Generated-by: Claude Code (Claude Opus 5.5)
Fixes #40476
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Optionally write chunk content to Qdrant payload [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40502:
URL: https://github.com/apache/beam/pull/40502#issuecomment-6102614145
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/40502?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 56.23%. Comparing base ([`76f6e6d`](https://app.codecov.io/gh/apache/beam/commit/76f6e6d7c0c1b2ce582c73d068ad9260cf15c5f3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`30227d4`](https://app.codecov.io/gh/apache/beam/commit/30227d42110b394d69f8bc0193f66a0a428df99e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 111 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #40502 +/- ##
============================================
+ Coverage 56.16% 56.23% +0.06%
Complexity 2288 2288
============================================
Files 1124 1124
Lines 178336 178367 +31
Branches 1489 1489
============================================
+ Hits 100170 100304 +134
+ Misses 75645 75542 -103
Partials 2521 2521
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/40502/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [python](https://app.codecov.io/gh/apache/beam/pull/40502/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.68% <100.00%> (+0.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/beam/pull/40502?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Optionally write chunk content to Qdrant payload [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40502:
URL: https://github.com/apache/beam/pull/40502#issuecomment-6102749017
Assigning reviewers:
R: @jrmccluskey for label python.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Optionally write chunk content to Qdrant payload [beam]
Posted by "claudevdm (via GitHub)" <gi...@apache.org>.
claudevdm merged PR #40502:
URL: https://github.com/apache/beam/pull/40502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org