[GitHub] [nuttx] acassis commented on a diff in pull request #9304: arm64/pinephone: Add driver for PinePhone LTE Modem (Quectel EG25-G)

["acassis (via GitHub)" <gi...@apache.org>]

acassis commented on code in PR #9304:
URL: https://github.com/apache/nuttx/pull/9304#discussion_r1196642676


##########
boards/arm64/a64/pinephone/Kconfig:
##########
@@ -17,4 +17,10 @@ config PINEPHONE_LCD
 	---help---
 		Select to enable support for LCD Display.
 
+config PINEPHONE_MODEM
+	bool "LTE Modem"
+	default n
+	---help---
+		Select to enable support for Quectel EG25-G LTE Modem.

Review Comment:
   @lupyuen I don't think there is a standard command driver for modems, because normally they are hardware dependent. Also I don't think these examples you cited are the right way to support Direct-IP modems on NuttX, Direct-IP modems need to use USRSOCK to integrated correctly with NuttX.
   
   If this modem supports PPP protocol then this is a good way to go (even been a legacy protocol it is well supported on NuttX). I friend of mine (@duduita) is using BG770A and BG95 (Cat-M1 and NB-IoT) with PPP on NuttX and it works fine.
   
   If this Quectel EG25-G is also connected to the USB and has support to MBIM protocol (MBIM and QMI are the most common protocols used on 4G modems) you can use the drivers/usbhost/usbhost_cdcmbim.c with it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org