You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/05 07:45:42 UTC

[GitHub] [airflow] kuromt opened a new pull request #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

kuromt opened a new pull request #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365
 
 
   add host_aliases paramter to KubernetesPodOperator.
   The parameter is set to pod.spec.hostAliases.
   Please see detail in [the kubernetes document](https://kubernetes.io/docs/concepts/services-networking/add-entries-to-pod-etc-hosts-with-host-aliases/).
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365#issuecomment-583515539
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=h1) Report
   > Merging [#7365](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/52db2abfffb5ffad6d1ed9c7e1b65762b51cda48?src=pr&el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7365/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7365      +/-   ##
   ==========================================
   - Coverage   86.06%   86.01%   -0.06%     
   ==========================================
     Files         871      871              
     Lines       40642    40644       +2     
   ==========================================
   - Hits        34980    34960      -20     
   - Misses       5662     5684      +22
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `93.68% <100%> (+23.47%)` | :arrow_up: |
   | [airflow/kubernetes/pod\_generator.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9nZW5lcmF0b3IucHk=) | `95.97% <100%> (+0.02%)` | :arrow_up: |
   | [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0%> (-72.16%)` | :arrow_down: |
   | [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50% <0%> (-50%)` | :arrow_down: |
   | [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0%> (-46.67%)` | :arrow_down: |
   | [airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=) | `61.53% <0%> (-38.47%)` | :arrow_down: |
   | [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `50.67% <0%> (-37.84%)` | :arrow_down: |
   | [airflow/providers/mongo/hooks/mongo.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vaG9va3MvbW9uZ28ucHk=) | `93.15% <0%> (-4.11%)` | :arrow_down: |
   | [airflow/executors/base\_executor.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvYmFzZV9leGVjdXRvci5weQ==) | `93.58% <0%> (-2.57%)` | :arrow_down: |
   | ... and [4 more](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=footer). Last update [52db2ab...9522d77](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365#issuecomment-583515539
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=h1) Report
   > Merging [#7365](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/967930c0cb6e2293f2a49e5c9add5aa1917f3527?src=pr&el=desc) will **decrease** coverage by `0.11%`.
   > The diff coverage is `89.71%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7365/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7365      +/-   ##
   ==========================================
   - Coverage   86.61%   86.49%   -0.12%     
   ==========================================
     Files         873      920      +47     
     Lines       40757    44338    +3581     
   ==========================================
   + Hits        35300    38349    +3049     
   - Misses       5457     5989     +532
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...iders/google/cloud/example\_dags/example\_spanner.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX3NwYW5uZXIucHk=) | `100% <ø> (ø)` | :arrow_up: |
   | [airflow/providers/presto/hooks/presto.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcHJlc3RvL2hvb2tzL3ByZXN0by5weQ==) | `75.92% <ø> (ø)` | :arrow_up: |
   | [airflow/providers/opsgenie/hooks/opsgenie\_alert.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvb3BzZ2VuaWUvaG9va3Mvb3BzZ2VuaWVfYWxlcnQucHk=) | `100% <ø> (ø)` | :arrow_up: |
   | [...ow/providers/google/cloud/utils/field\_validator.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL3V0aWxzL2ZpZWxkX3ZhbGlkYXRvci5weQ==) | `92.37% <ø> (+0.06%)` | :arrow_up: |
   | [...roviders/google/cloud/operators/gcs\_to\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9nY3NfdG9fYmlncXVlcnkucHk=) | `92.95% <ø> (+22.36%)` | :arrow_up: |
   | [...low/providers/google/cloud/operators/gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9nY3NfdG9fZ2NzLnB5) | `90.9% <ø> (-4.75%)` | :arrow_down: |
   | [...rflow/providers/google/firebase/hooks/firestore.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2ZpcmViYXNlL2hvb2tzL2ZpcmVzdG9yZS5weQ==) | `97.29% <ø> (ø)` | |
   | [...ow/providers/google/cloud/operators/sftp\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9zZnRwX3RvX2djcy5weQ==) | `100% <ø> (ø)` | :arrow_up: |
   | [airflow/providers/google/cloud/hooks/gcs.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL2djcy5weQ==) | `85.46% <ø> (-0.06%)` | :arrow_down: |
   | [...flow/providers/google/cloud/operators/translate.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy90cmFuc2xhdGUucHk=) | `85.18% <ø> (ø)` | :arrow_up: |
   | ... and [369 more](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=footer). Last update [967930c...ba5fdf3](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

Posted by GitBox <gi...@apache.org>.

ashb commented on a change in pull request #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365#discussion_r378796979
 
 

 ##########
 File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
 ##########
 @@ -110,6 +110,8 @@ class KubernetesPodOperator(BaseOperator):  # pylint: disable=too-many-instance-
     :type is_delete_operator_pod: bool
     :param hostnetwork: If True enable host networking on the pod.
     :type hostnetwork: bool
+    :param host_aliases: A list of hostAliases.
+    :type host_aliases: list hostAliases
 
 Review comment:
   ```suggestion
       :type host_aliases: list
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kuromt commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

Posted by GitBox <gi...@apache.org>.

kuromt commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365#issuecomment-607611924
 
 
   The latest test failed due to timeout, but this fail is due to timing problem.
   Should I kick off test again?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kuromt commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

Posted by GitBox <gi...@apache.org>.

kuromt commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365#issuecomment-586053550
 
 
   ```
   No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
   Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received
   The build has been terminated
   ```
   
   @ashb I merged your request, but It seems that travis has a problem.
   Could you retry the building job?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365#issuecomment-582281701

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [airflow] kuromt commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

Posted by GitBox <gi...@apache.org>.

kuromt commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365#issuecomment-605904306
 
 
   After extending timeout to 200, the test passed.
   ```
   pytest tests/runtime/kubernetes/test_kubernetes_executor.py 
   ==================================================================== test session starts ====================================================================
   platform linux -- Python 3.6.10, pytest-5.4.1, py-1.8.1, pluggy-0.13.1 -- /usr/local/bin/python
   cachedir: .pytest_cache
   rootdir: /opt/airflow, inifile: pytest.ini
   plugins: celery-4.4.2, requests-mock-1.7.0, instafail-0.4.1.post0, cov-2.8.1, flaky-3.6.1
   collected 2 items                                                                                                                                           
   
   tests/runtime/kubernetes/test_kubernetes_executor.py::TestKubernetesExecutor::test_integration_run_dag PASSED                                         [ 50%]
   tests/runtime/kubernetes/test_kubernetes_executor.py::TestKubernetesExecutor::test_integration_run_dag_with_scheduler_failure PASSED                  [100%]
   
   =============================================================== 2 passed in 613.74s (0:10:13) ===============================================================
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365#issuecomment-583515539
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=h1) Report
   > Merging [#7365](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6018532d21796e04fdf47a77f36ae8308cc928ba&el=desc) will **decrease** coverage by `27.24%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7365/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #7365       +/-   ##
   ===========================================
   - Coverage   87.17%   59.93%   -27.25%     
   ===========================================
     Files         933      933               
     Lines       45290    45292        +2     
   ===========================================
   - Hits        39482    27145    -12337     
   - Misses       5808    18147    +12339     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/kubernetes/pod\_generator.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9nZW5lcmF0b3IucHk=) | `96.53% <100.00%> (+0.01%)` | :arrow_up: |
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `70.00% <100.00%> (-24.95%)` | :arrow_down: |
   | [airflow/providers/amazon/aws/hooks/kinesis.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9raW5lc2lzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [airflow/providers/apache/livy/sensors/livy.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2xpdnkvc2Vuc29ycy9saXZ5LnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [airflow/providers/amazon/aws/sensors/redshift.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9zZW5zb3JzL3JlZHNoaWZ0LnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [airflow/providers/microsoft/azure/operators/adx.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbWljcm9zb2Z0L2F6dXJlL29wZXJhdG9ycy9hZHgucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...irflow/providers/amazon/aws/hooks/batch\_waiters.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9iYXRjaF93YWl0ZXJzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ow/providers/amazon/aws/sensors/cloud\_formation.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9zZW5zb3JzL2Nsb3VkX2Zvcm1hdGlvbi5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [313 more](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=footer). Last update [6018532...22b02e8](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kuromt edited a comment on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

Posted by GitBox <gi...@apache.org>.

kuromt edited a comment on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365#issuecomment-605832159
 
 
   Thanks for your pointing.
   ~Aftrer I rebased current apache/master  to this PR in local branch, tests are passed.~
   
   Test failed replicates in my environemnt.
   I'll debug.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

Posted by GitBox <gi...@apache.org>.

codecov-io commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365#issuecomment-583515539
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=h1) Report
   > Merging [#7365](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/52db2abfffb5ffad6d1ed9c7e1b65762b51cda48?src=pr&el=desc) will **decrease** coverage by `0.33%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7365/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7365      +/-   ##
   ==========================================
   - Coverage   86.06%   85.73%   -0.34%     
   ==========================================
     Files         871      871              
     Lines       40642    40644       +2     
   ==========================================
   - Hits        34980    34845     -135     
   - Misses       5662     5799     +137
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `93.68% <100%> (+23.47%)` | :arrow_up: |
   | [airflow/kubernetes/pod\_generator.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9nZW5lcmF0b3IucHk=) | `95.97% <100%> (+0.02%)` | :arrow_up: |
   | [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0%> (-72.16%)` | :arrow_down: |
   | [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0%> (-64.16%)` | :arrow_down: |
   | [airflow/api/auth/backend/kerberos\_auth.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvYXV0aC9iYWNrZW5kL2tlcmJlcm9zX2F1dGgucHk=) | `28.16% <0%> (-54.93%)` | :arrow_down: |
   | [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50% <0%> (-50%)` | :arrow_down: |
   | [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0%> (-46.67%)` | :arrow_down: |
   | [airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==) | `30.43% <0%> (-45.66%)` | :arrow_down: |
   | [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55% <0%> (-45%)` | :arrow_down: |
   | [airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=) | `61.53% <0%> (-38.47%)` | :arrow_down: |
   | ... and [12 more](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=footer). Last update [52db2ab...9522d77](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kuromt commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

Posted by GitBox <gi...@apache.org>.

kuromt commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365#issuecomment-605832159
 
 
   Thanks for your pointing.
   Aftrer I rebased current apache/master  to this PR in local branch, tests are passed.
   
   ```
    pytest tests/runtime/kubernetes/test_kubernetes_executor.py 
   ================================================================================================= test session starts =================================================================================================
   platform linux -- Python 3.6.10, pytest-5.4.1, py-1.8.1, pluggy-0.13.1 -- /usr/local/bin/python
   cachedir: .pytest_cache
   rootdir: /opt/airflow, inifile: pytest.ini
   plugins: celery-4.4.2, flaky-3.6.1, cov-2.8.1, instafail-0.4.1.post0, requests-mock-1.7.0
   collected 2 items                                                                                                                                                                                                     
   
   tests/runtime/kubernetes/test_kubernetes_executor.py::TestKubernetesExecutor::test_integration_run_dag PASSED                                                                                                   [ 50%]
   tests/runtime/kubernetes/test_kubernetes_executor.py::TestKubernetesExecutor::test_integration_run_dag_with_scheduler_failure PASSED                                                                            [100%]
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365#issuecomment-583515539
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=h1) Report
   > Merging [#7365](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9e09fa3c94e6bab98d9557ef2c3a341249d5f746?src=pr&el=desc) will **increase** coverage by `53.89%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7365/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #7365       +/-   ##
   ===========================================
   + Coverage   32.59%   86.49%   +53.89%     
   ===========================================
     Files         871      871               
     Lines       40660    40662        +2     
   ===========================================
   + Hits        13253    35170    +21917     
   + Misses      27407     5492    -21915
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `93.68% <100%> (+0.06%)` | :arrow_up: |
   | [airflow/kubernetes/pod\_generator.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9nZW5lcmF0b3IucHk=) | `95.97% <100%> (+42.21%)` | :arrow_up: |
   | [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | :arrow_up: |
   | [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `86.95% <0%> (+0.72%)` | :arrow_up: |
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (+2.1%)` | :arrow_up: |
   | [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
   | [airflow/utils/decorators.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kZWNvcmF0b3JzLnB5) | `90.47% <0%> (+4.76%)` | :arrow_up: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `92.25% <0%> (+5.63%)` | :arrow_up: |
   | [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `52.94% <0%> (+5.88%)` | :arrow_up: |
   | [airflow/www/forms.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvZm9ybXMucHk=) | `100% <0%> (+8%)` | :arrow_up: |
   | ... and [738 more](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=footer). Last update [9e09fa3...fd68dc8](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365#issuecomment-583515539
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=h1) Report
   > Merging [#7365](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9e09fa3c94e6bab98d9557ef2c3a341249d5f746?src=pr&el=desc) will **increase** coverage by `53.63%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7365/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #7365       +/-   ##
   ===========================================
   + Coverage   32.59%   86.22%   +53.63%     
   ===========================================
     Files         871      871               
     Lines       40660    40662        +2     
   ===========================================
   + Hits        13253    35061    +21808     
   + Misses      27407     5601    -21806
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `93.68% <100%> (+0.06%)` | :arrow_up: |
   | [airflow/kubernetes/pod\_generator.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9nZW5lcmF0b3IucHk=) | `95.97% <100%> (+42.21%)` | :arrow_up: |
   | [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | :arrow_up: |
   | [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `86.95% <0%> (+0.72%)` | :arrow_up: |
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (+2.1%)` | :arrow_up: |
   | [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
   | [airflow/utils/decorators.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kZWNvcmF0b3JzLnB5) | `90.47% <0%> (+4.76%)` | :arrow_up: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `92.25% <0%> (+5.63%)` | :arrow_up: |
   | [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `52.94% <0%> (+5.88%)` | :arrow_up: |
   | [airflow/www/forms.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvZm9ybXMucHk=) | `100% <0%> (+8%)` | :arrow_up: |
   | ... and [734 more](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=footer). Last update [9e09fa3...fd68dc8](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365#issuecomment-583515539
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=h1) Report
   > Merging [#7365](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9e09fa3c94e6bab98d9557ef2c3a341249d5f746?src=pr&el=desc) will **increase** coverage by `53.99%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7365/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #7365       +/-   ##
   ===========================================
   + Coverage   32.59%   86.59%   +53.99%     
   ===========================================
     Files         871      871               
     Lines       40660    40662        +2     
   ===========================================
   + Hits        13253    35210    +21957     
   + Misses      27407     5452    -21955
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `93.68% <100%> (+0.06%)` | :arrow_up: |
   | [airflow/kubernetes/pod\_generator.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9nZW5lcmF0b3IucHk=) | `95.97% <100%> (+42.21%)` | :arrow_up: |
   | [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | :arrow_up: |
   | [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `86.95% <0%> (+0.72%)` | :arrow_up: |
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (+2.1%)` | :arrow_up: |
   | [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
   | [airflow/utils/decorators.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kZWNvcmF0b3JzLnB5) | `90.47% <0%> (+4.76%)` | :arrow_up: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `92.25% <0%> (+5.63%)` | :arrow_up: |
   | [airflow/www/forms.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvZm9ybXMucHk=) | `100% <0%> (+8%)` | :arrow_up: |
   | [airflow/utils/timeout.py](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy90aW1lb3V0LnB5) | `75% <0%> (+8.33%)` | :arrow_up: |
   | ... and [739 more](https://codecov.io/gh/apache/airflow/pull/7365/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=footer). Last update [9e09fa3...fd68dc8](https://codecov.io/gh/apache/airflow/pull/7365?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

Posted by GitBox <gi...@apache.org>.

ashb commented on a change in pull request #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365#discussion_r378797351
 
 

 ##########
 File path: airflow/kubernetes/pod_generator.py
 ##########
 @@ -116,6 +116,8 @@ class PodGenerator:
     :type affinity: Optional[dict]
     :param hostnetwork: If True enable host networking on the pod
     :type hostnetwork: bool
+    :param host_aliases: A list of hostAliases.
+    :type host_aliases: list hostAliases
 
 Review comment:
   ```suggestion
       :type host_aliases: list
   ```
   
   Plus somewhere (not the type) a link to what structure this should have.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] dimberman commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

Posted by GitBox <gi...@apache.org>.

dimberman commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365#issuecomment-601318150
 
 
   @ashb as the config rewrite is down the road I'm good to merge this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] dimberman commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

Posted by GitBox <gi...@apache.org>.

dimberman commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365#issuecomment-603984814
 
 
   ```
   tests/runtime/kubernetes/test_kubernetes_executor.py .F
   
   ____ TestKubernetesExecutor.test_integration_run_dag_with_scheduler_failure ____
   
   self = <tests.runtime.kubernetes.test_kubernetes_executor.TestKubernetesExecutor testMethod=test_integration_run_dag_with_scheduler_failure>
   
       def test_integration_run_dag_with_scheduler_failure(self):
   
           host = KUBERNETES_HOST
   
           dag_id = 'example_kubernetes_executor_config'
   
       
   
           result_json = self.start_dag(dag_id=dag_id, host=host)
   
       
   
           self.assertGreater(len(result_json['items']), 0)
   
       
   
           execution_date = result_json['items'][0]['execution_date']
   
           print("Found the job with execution date {}".format(execution_date))
   
       
   
           self._delete_airflow_pod()
   
       
   
           time.sleep(10)  # give time for pod to restart
   
       
   
           # Wait some time for the operator to complete
   
           self.monitor_task(host=host,
   
                             execution_date=execution_date,
   
                             dag_id=dag_id,
   
                             task_id='start_task',
   
                             expected_final_state='success', timeout=200)
   
       
   
           self.monitor_task(host=host,
   
                             execution_date=execution_date,
   
                             dag_id=dag_id,
   
                             task_id='other_namespace_task',
   
   >                         expected_final_state='success', timeout=200)
   
   tests/runtime/kubernetes/test_kubernetes_executor.py:231: 
   
   _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
   
   tests/runtime/kubernetes/test_kubernetes_executor.py:107: in monitor_task
   
       self.assertEqual(state, expected_final_state)
   
   E   AssertionError: '' != 'success'
   
   E   + success
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kuromt commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

Posted by GitBox <gi...@apache.org>.

kuromt commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365#issuecomment-603606530
 
 
   > @ashb as the config rewrite is down the road I'm good to merge this.
   
   Thanks!
   
   `pod_generator.py` is updated after my PR, so If I needed to rebase and commit again to merge this PR, please let me know.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services