You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2022/02/08 16:49:07 UTC
[GitHub] [sling-org-apache-sling-testing-clients] andreituicu commented on a change in pull request #28: SLING-11131 - Update Apache HTTP Client Dependency for CVE-2020-13956
andreituicu commented on a change in pull request #28:
URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/28#discussion_r801845904
##########
File path: src/test/java/org/apache/sling/testing/AbstractSlingClientGetUrlTest.java
##########
@@ -130,7 +130,7 @@ public void testGetUrlWithParam() throws ClientException {
SlingClient c = new SlingClient(URI.create(serverUrl), "USER", "PWD");
assertEquals("", URI.create(expectedUrl), c.getUrl(inputPath));
assertEquals(URI.create(expectedUrl), c.getUrl(inputPath, null));
- assertEquals(URI.create(expectedUrl + "?"), c.getUrl(inputPath, new ArrayList<NameValuePair>()));
+ assertEquals(URI.create(expectedUrl), c.getUrl(inputPath, new ArrayList<NameValuePair>()));
Review comment:
@dulvac : It looks like the behaviour changed in the httpclient for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org