You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "voonhous (via GitHub)" <gi...@apache.org> on 2023/04/21 08:59:34 UTC

[GitHub] [hudi] voonhous opened a new pull request, #8534: [MINOR] Fix misleading write operation value

voonhous opened a new pull request, #8534:
URL: https://github.com/apache/hudi/pull/8534

   ### Change Logs
   
   Permitted write operation values do not align with what is actually described in configuration value. 
   
   This PR fixes this so that the permitted write operations aligns with the description. This change is required as Hudi's documentation page is generated from the description of each configuration key.
   
   ### Impact
   None
   
   ### Risk level (write none, low medium or high below)
   Low
   
   ### Documentation Update
   
   No functionality changes, documentation description update to change ~~bulkinsert~~ to bulk_insert.
   
   This change will "hopefully" prevent NEW users from doing this when they are performing a bulk insert operation in their batch SQL jobs.
   
   **WRONG:**
   
   ```sql
   set hoodie.datasource.write.operation=bulkinsert;
   ```
   
   **CORRECT:**
   
   ```sql
   set hoodie.datasource.write.operation=bulk_insert;
   ```
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8534: [MINOR] Fix misleading permitted write operation value

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8534:
URL: https://github.com/apache/hudi/pull/8534#issuecomment-1517521336

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0dfb2388ac4261298870c6753dc0873938a797f9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0dfb2388ac4261298870c6753dc0873938a797f9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0dfb2388ac4261298870c6753dc0873938a797f9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8534: [MINOR] Fix misleading permitted write operation value

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8534:
URL: https://github.com/apache/hudi/pull/8534#issuecomment-1517531547

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0dfb2388ac4261298870c6753dc0873938a797f9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16526",
       "triggerID" : "0dfb2388ac4261298870c6753dc0873938a797f9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0dfb2388ac4261298870c6753dc0873938a797f9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16526) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar merged pull request #8534: [MINOR] Fix misleading permitted write operation value

Posted by "vinothchandar (via GitHub)" <gi...@apache.org>.
vinothchandar merged PR #8534:
URL: https://github.com/apache/hudi/pull/8534


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8534: [MINOR] Fix misleading permitted write operation value

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8534:
URL: https://github.com/apache/hudi/pull/8534#issuecomment-1518371722

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0dfb2388ac4261298870c6753dc0873938a797f9",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16526",
       "triggerID" : "0dfb2388ac4261298870c6753dc0873938a797f9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0dfb2388ac4261298870c6753dc0873938a797f9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16526) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org