You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/14 23:36:02 UTC
[GitHub] [spark] jose-torres commented on issue #26114: [SPARK-29468][SQL]
Change Literal.sql to be correct for floats.
jose-torres commented on issue #26114: [SPARK-29468][SQL] Change Literal.sql to be correct for floats.
URL: https://github.com/apache/spark/pull/26114#issuecomment-541974259
I kept the new test suite even though the hive tests were revealed to also be relevant, since I think they're not quite the same thing (the hive tests don't verify the output can be re-parsed) and it's weird to rely only on hive module tests for a SQL core functionality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org