[GitHub] [druid] FrankChen021 edited a comment on pull request #10383: [WIP]Fix ingestion failure of pretty-formatted JSON message

[GitBox <gi...@apache.org>]

FrankChen021 edited a comment on pull request #10383:
URL: https://github.com/apache/druid/pull/10383#issuecomment-693185689


   Marked as WIP temporarily.
   
   `JsonReader.hasNext`, which calls the jackson's `MappingIterator.hasNext`, throws exception when a json text is ill-formed, this causes some old test cases on `sample` to fail while test cases on `read` are successfully passed. This is because stream ingestion handle each record one by one, and if one fails to parse json text, exception is caught and handled gracefully, while `sample` treats all records as a whole if one record fails, the sample process aborts.
   
   It would take some time to handle this problem.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org