You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Stepan Mishura <st...@gmail.com> on 2008/03/18 06:08:34 UTC
RE: svn commit: r637937 - in /harmony/enhanced/jdktools/trunk/modules/jpda: ....
Hi Oliver,
Your commit broke Linux build. Could you fix it or roll it back?
The build fails with:
[java] -clean-native-windows:
[java] [echo] Making "clean" in
/export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/modules/jpda/src/main/native/jdwp/unix/transport/dt_shmem
[java] [echo] LOCAL MAKE DEFN L
/export/users/cc/cc-common/build/checkouts/hdk/working_vm/deploy
[java]
[java] BUILD FAILED
[java] /export/users/cc/cc-common/build/checkouts/hdk/build.xml:444:
The following error occurred while executing this line:
[java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/build.xml:200:
The following error occurred while executing this line:
[java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/make/build-native.xml:69:
The following error occurred while executing this line:
[java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/make/properties.xml:336:
The following error occurred while executing this line:
[java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/modules/jpda/build.xml:185:
The following error occurred while executing this line:
[java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/modules/jpda/build.xml:189:
The following error occurred while executing this line:
[java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/make/properties.xml:354:
The directory you specified does not exist
Thanks,
Stepan.
-----Original Message-----
From: odeakin@apache.org [mailto:odeakin@apache.org]
Sent: Monday, March 17, 2008 9:18 PM
To: commits@harmony.apache.org
Subject: svn commit: r637937 - in
/harmony/enhanced/jdktools/trunk/modules/jpda: ./
src/main/native/jdwp/common/transport/common/
src/main/native/jdwp/unix/transport/
src/main/native/jdwp/unix/transport/dt_socket/
src/main/native/jdwp/windows/transport/ src/mai...
Author: odeakin
Date: Mon Mar 17 08:17:35 2008
New Revision: 637937
URL: http://svn.apache.org/viewvc?rev=637937&view=rev
Log:
Some changes to start implementation of JDWP shared memory transport:
- Reorganisation of socket transport makefiles into their own subdirectories.
- Initial check-in of shared memory transport code.
- Alteration to build.xml to start building dt_shmem.dll on Windows.
Added:
harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/dt_socket/exports.txt
- copied unchanged from r636747,
harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/exports.txt
harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/dt_socket/makefile
- copied, changed from r636747,
harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/makefile
harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/
harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/SharedMemTransport.cpp
(with props)
harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/SharedMemTransport.h
(with props)
harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/dt_shmem.def
harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/makefile
harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_socket/makefile
- copied, changed from r636747,
harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/makefile
Removed:
harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/exports.txt
harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/makefile
harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/makefile
Modified:
harmony/enhanced/jdktools/trunk/modules/jpda/build.xml
harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/common/transport/common/LastTransportError.h
Modified: harmony/enhanced/jdktools/trunk/modules/jpda/build.xml
URL: http://svn.apache.org/viewvc/harmony/enhanced/jdktools/trunk/modules/jpda/build.xml?rev=637937&r1=637936&r2=637937&view=diff
==============================================================================
<SNIP>
Re: svn commit: r637937 - in /harmony/enhanced/jdktools/trunk/modules/jpda: ....
Posted by Stepan Mishura <st...@gmail.com>.
On 3/20/08, Stepan Mishura <st...@gmail.com> wrote:
<SNIP>
>
> But you missed my point - usually (not this particular case) there are
s/not/not only/
-Stepan.
> dozens of commits between build breakage and its recovery. IMHO that
> definitely means that people don't pay attention to alerts and don't
> look at the integrity page.
> Also it may mean that:
> - commits are not monitored (IOW, the last/fresh code from repository
> is not used)
> - unit tests are not run
> - regressions are not evaluated early.
> (The last two points are nightmare for QA engineer :-))
>
> Seriously speaking, I think we established good (not perfect, but
> anyway I do believe it is good) testing process to assists developer.
> Say, a developer doesn't need to run all suites included into
> integrity testing on all platforms. She/he may run only selected tests
> (I assume that most of developers test changes in this way) on couple
> of platforms(Linux/Windows) and if everything pass then changes are
> committed. And she/he have opportunity to see all tests results on all
> platforms pretty soon(~5 hours). Wow!
> ... and what are reasons to ignore such opportunity?
>
> Thanks,
> Stepan.
>
> > Regards,
> > Tim
> >
> >
>
Re: svn commit: r637937 - in /harmony/enhanced/jdktools/trunk/modules/jpda: ....
Posted by Stepan Mishura <st...@gmail.com>.
On 3/19/08, Tim Ellison <t....@gmail.com> wrote:
> Stepan Mishura wrote:
> > On 3/19/08, Oliver Deakin <ol...@googlemail.com> wrote:
> >> Hi Stepan,
> >>
> >> Thanks for fixing that! I did do a build on Linux at the time, but it
> >> was a sequential build from an already existing workspace so it must
> >> have missed that change somehow. Ill build from scratch next time to
> >> make sure!
> >> I do watch the alerts list, and I fixed the build break I saw (the one
> >> you raised initially), but received no further mails indicating a break
> >> on Linux x86. I take it a mail only gets sent when the state of the
> >> build changes? So if there is a second break (as in this case) no mail
> >> is sent because the build state does not change?
> >
> > Yes, it is. If the build is broken than only initial notification is
> > sent, no repeated notifications are sent.
> >
> > It is expected that once committers see a notification about build
> > breakage all commits are stopped and everybody wait when the build is
> > fixed and notification about build recovery is received - I think
> > everybody should know that if the build is broken no tests are run. We
> > tried to establish a practice with stopping commits but it seems that
> > people don't like to follow it :-)
>
> Like you say, if somebody breaks the build (via the alert notifications
> etc.) then it is their duty to fix it (i.e. see the successful message).
> It's pretty simple.
>
Yes, that true.
But you missed my point - usually (not this particular case) there are
dozens of commits between build breakage and its recovery. IMHO that
definitely means that people don't pay attention to alerts and don't
look at the integrity page.
Also it may mean that:
- commits are not monitored (IOW, the last/fresh code from repository
is not used)
- unit tests are not run
- regressions are not evaluated early.
(The last two points are nightmare for QA engineer :-))
Seriously speaking, I think we established good (not perfect, but
anyway I do believe it is good) testing process to assists developer.
Say, a developer doesn't need to run all suites included into
integrity testing on all platforms. She/he may run only selected tests
(I assume that most of developers test changes in this way) on couple
of platforms(Linux/Windows) and if everything pass then changes are
committed. And she/he have opportunity to see all tests results on all
platforms pretty soon(~5 hours). Wow!
... and what are reasons to ignore such opportunity?
Thanks,
Stepan.
> Regards,
> Tim
>
>
Re: svn commit: r637937 - in /harmony/enhanced/jdktools/trunk/modules/jpda:
....
Posted by Tim Ellison <t....@gmail.com>.
Stepan Mishura wrote:
> On 3/19/08, Oliver Deakin <ol...@googlemail.com> wrote:
>> Hi Stepan,
>>
>> Thanks for fixing that! I did do a build on Linux at the time, but it
>> was a sequential build from an already existing workspace so it must
>> have missed that change somehow. Ill build from scratch next time to
>> make sure!
>> I do watch the alerts list, and I fixed the build break I saw (the one
>> you raised initially), but received no further mails indicating a break
>> on Linux x86. I take it a mail only gets sent when the state of the
>> build changes? So if there is a second break (as in this case) no mail
>> is sent because the build state does not change?
>
> Yes, it is. If the build is broken than only initial notification is
> sent, no repeated notifications are sent.
>
> It is expected that once committers see a notification about build
> breakage all commits are stopped and everybody wait when the build is
> fixed and notification about build recovery is received - I think
> everybody should know that if the build is broken no tests are run. We
> tried to establish a practice with stopping commits but it seems that
> people don't like to follow it :-)
Like you say, if somebody breaks the build (via the alert notifications
etc.) then it is their duty to fix it (i.e. see the successful message).
It's pretty simple.
Regards,
Tim
Re: svn commit: r637937 - in /harmony/enhanced/jdktools/trunk/modules/jpda:
....
Posted by Oliver Deakin <ol...@googlemail.com>.
Stepan Mishura wrote:
> On 3/19/08, Oliver Deakin <ol...@googlemail.com> wrote:
>
>> Hi Stepan,
>>
>> Thanks for fixing that! I did do a build on Linux at the time, but it
>> was a sequential build from an already existing workspace so it must
>> have missed that change somehow. Ill build from scratch next time to
>> make sure!
>> I do watch the alerts list, and I fixed the build break I saw (the one
>> you raised initially), but received no further mails indicating a break
>> on Linux x86. I take it a mail only gets sent when the state of the
>> build changes? So if there is a second break (as in this case) no mail
>> is sent because the build state does not change?
>>
>
> Yes, it is. If the build is broken than only initial notification is
> sent, no repeated notifications are sent.
>
Ah, thanks Stepan - Ill watch the integrity page from now on instead!
Regards,
Oliver
> It is expected that once committers see a notification about build
> breakage all commits are stopped and everybody wait when the build is
> fixed and notification about build recovery is received - I think
> everybody should know that if the build is broken no tests are run. We
> tried to establish a practice with stopping commits but it seems that
> people don't like to follow it :-)
>
> -Stepan.
>
>
>> I will keep my eye on
>> the integrity page from now on instead to make sure.
>>
>> Regards,
>> Oliver
>>
>> Stepan Mishura wrote:
>>
>>> On 3/18/08, Oliver Deakin <ol...@googlemail.com> wrote:
>>>
>>>
>>>> Sorry about this - there was a missing "is.windows" check for the
>>>> dt_shmem clean target. Should be fixed at r638284.
>>>>
>>>>
>>>>
>>> Unfortunately, this didn't fully fix the Linux build - the makefile
>>> also had to be adjusted (I fixed it at r638711).
>>>
>>> Oliver, if you don't have access to the Linux host why you don't use
>>> integrity status page [1] to check that your updates don't break
>>> anything? The page is updated regularly and it is possible to know
>>> effect of your changes in hours. Also there is an alerts list
>>> (alerts@harmony.apache.org). The list is used for alerts notifications
>>> for suites included into integrity testing. So if you were subscribed
>>> to the list, updated the build and get notification about broken build
>>> then that would mean that probably your changes broke the build.
>>>
>>> And the best way to avoid broken builds is to check changes before
>>> committing on both platforms :-)
>>>
>>> [1] http://people.apache.org/~varlax/harmony-integrity/
>>>
>>> Thanks,
>>> Stepan.
>>>
>>>
>>>
>>>> Regards,
>>>> Oliver
>>>>
>>>> Stepan Mishura wrote:
>>>>
>>>>
>>>>> Hi Oliver,
>>>>>
>>>>> Your commit broke Linux build. Could you fix it or roll it back?
>>>>>
>>>>> The build fails with:
>>>>>
>>>>> [java] -clean-native-windows:
>>>>> [java] [echo] Making "clean" in
>>>>> /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/modules/jpda/src/main/native/jdwp/unix/transport/dt_shmem
>>>>> [java] [echo] LOCAL MAKE DEFN L
>>>>> /export/users/cc/cc-common/build/checkouts/hdk/working_vm/deploy
>>>>> [java]
>>>>> [java] BUILD FAILED
>>>>> [java] /export/users/cc/cc-common/build/checkouts/hdk/build.xml:444:
>>>>> The following error occurred while executing this line:
>>>>> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/build.xml:200:
>>>>> The following error occurred while executing this line:
>>>>> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/make/build-native.xml:69:
>>>>> The following error occurred while executing this line:
>>>>> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/make/properties.xml:336:
>>>>> The following error occurred while executing this line:
>>>>> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/modules/jpda/build.xml:185:
>>>>> The following error occurred while executing this line:
>>>>> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/modules/jpda/build.xml:189:
>>>>> The following error occurred while executing this line:
>>>>> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/make/properties.xml:354:
>>>>> The directory you specified does not exist
>>>>>
>>>>> Thanks,
>>>>> Stepan.
>>>>>
>>>>> -----Original Message-----
>>>>> From: odeakin@apache.org [mailto:odeakin@apache.org]
>>>>> Sent: Monday, March 17, 2008 9:18 PM
>>>>> To: commits@harmony.apache.org
>>>>> Subject: svn commit: r637937 - in
>>>>> /harmony/enhanced/jdktools/trunk/modules/jpda: ./
>>>>> src/main/native/jdwp/common/transport/common/
>>>>> src/main/native/jdwp/unix/transport/
>>>>> src/main/native/jdwp/unix/transport/dt_socket/
>>>>> src/main/native/jdwp/windows/transport/ src/mai...
>>>>>
>>>>> Author: odeakin
>>>>> Date: Mon Mar 17 08:17:35 2008
>>>>> New Revision: 637937
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=637937&view=rev
>>>>> Log:
>>>>> Some changes to start implementation of JDWP shared memory transport:
>>>>> - Reorganisation of socket transport makefiles into their own subdirectories.
>>>>> - Initial check-in of shared memory transport code.
>>>>> - Alteration to build.xml to start building dt_shmem.dll on Windows.
>>>>>
>>>>> Added:
>>>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/dt_socket/exports.txt
>>>>> - copied unchanged from r636747,
>>>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/exports.txt
>>>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/dt_socket/makefile
>>>>> - copied, changed from r636747,
>>>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/makefile
>>>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/
>>>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/SharedMemTransport.cpp
>>>>> (with props)
>>>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/SharedMemTransport.h
>>>>> (with props)
>>>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/dt_shmem.def
>>>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/makefile
>>>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_socket/makefile
>>>>> - copied, changed from r636747,
>>>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/makefile
>>>>> Removed:
>>>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/exports.txt
>>>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/makefile
>>>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/makefile
>>>>> Modified:
>>>>> harmony/enhanced/jdktools/trunk/modules/jpda/build.xml
>>>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/common/transport/common/LastTransportError.h
>>>>>
>>>>> Modified: harmony/enhanced/jdktools/trunk/modules/jpda/build.xml
>>>>> URL: http://svn.apache.org/viewvc/harmony/enhanced/jdktools/trunk/modules/jpda/build.xml?rev=637937&r1=637936&r2=637937&view=diff
>>>>> ==============================================================================
>>>>>
>>>>> <SNIP>
>>>>>
>>>>>
>>>>>
>>>>>
>>>> --
>>>> Oliver Deakin
>>>> Unless stated otherwise above:
>>>> IBM United Kingdom Limited - Registered in England and Wales with number 741598.
>>>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>>>>
>>>>
>>>>
>>>>
>>>
>> --
>> Oliver Deakin
>> Unless stated otherwise above:
>> IBM United Kingdom Limited - Registered in England and Wales with number 741598.
>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>>
>>
>>
>
>
--
Oliver Deakin
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
Re: svn commit: r637937 - in /harmony/enhanced/jdktools/trunk/modules/jpda: ....
Posted by Stepan Mishura <st...@gmail.com>.
On 3/19/08, Oliver Deakin <ol...@googlemail.com> wrote:
> Hi Stepan,
>
> Thanks for fixing that! I did do a build on Linux at the time, but it
> was a sequential build from an already existing workspace so it must
> have missed that change somehow. Ill build from scratch next time to
> make sure!
> I do watch the alerts list, and I fixed the build break I saw (the one
> you raised initially), but received no further mails indicating a break
> on Linux x86. I take it a mail only gets sent when the state of the
> build changes? So if there is a second break (as in this case) no mail
> is sent because the build state does not change?
Yes, it is. If the build is broken than only initial notification is
sent, no repeated notifications are sent.
It is expected that once committers see a notification about build
breakage all commits are stopped and everybody wait when the build is
fixed and notification about build recovery is received - I think
everybody should know that if the build is broken no tests are run. We
tried to establish a practice with stopping commits but it seems that
people don't like to follow it :-)
-Stepan.
> I will keep my eye on
> the integrity page from now on instead to make sure.
>
> Regards,
> Oliver
>
> Stepan Mishura wrote:
> > On 3/18/08, Oliver Deakin <ol...@googlemail.com> wrote:
> >
> >> Sorry about this - there was a missing "is.windows" check for the
> >> dt_shmem clean target. Should be fixed at r638284.
> >>
> >>
> >
> > Unfortunately, this didn't fully fix the Linux build - the makefile
> > also had to be adjusted (I fixed it at r638711).
> >
> > Oliver, if you don't have access to the Linux host why you don't use
> > integrity status page [1] to check that your updates don't break
> > anything? The page is updated regularly and it is possible to know
> > effect of your changes in hours. Also there is an alerts list
> > (alerts@harmony.apache.org). The list is used for alerts notifications
> > for suites included into integrity testing. So if you were subscribed
> > to the list, updated the build and get notification about broken build
> > then that would mean that probably your changes broke the build.
> >
> > And the best way to avoid broken builds is to check changes before
> > committing on both platforms :-)
> >
> > [1] http://people.apache.org/~varlax/harmony-integrity/
> >
> > Thanks,
> > Stepan.
> >
> >
> >> Regards,
> >> Oliver
> >>
> >> Stepan Mishura wrote:
> >>
> >>> Hi Oliver,
> >>>
> >>> Your commit broke Linux build. Could you fix it or roll it back?
> >>>
> >>> The build fails with:
> >>>
> >>> [java] -clean-native-windows:
> >>> [java] [echo] Making "clean" in
> >>> /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/modules/jpda/src/main/native/jdwp/unix/transport/dt_shmem
> >>> [java] [echo] LOCAL MAKE DEFN L
> >>> /export/users/cc/cc-common/build/checkouts/hdk/working_vm/deploy
> >>> [java]
> >>> [java] BUILD FAILED
> >>> [java] /export/users/cc/cc-common/build/checkouts/hdk/build.xml:444:
> >>> The following error occurred while executing this line:
> >>> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/build.xml:200:
> >>> The following error occurred while executing this line:
> >>> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/make/build-native.xml:69:
> >>> The following error occurred while executing this line:
> >>> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/make/properties.xml:336:
> >>> The following error occurred while executing this line:
> >>> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/modules/jpda/build.xml:185:
> >>> The following error occurred while executing this line:
> >>> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/modules/jpda/build.xml:189:
> >>> The following error occurred while executing this line:
> >>> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/make/properties.xml:354:
> >>> The directory you specified does not exist
> >>>
> >>> Thanks,
> >>> Stepan.
> >>>
> >>> -----Original Message-----
> >>> From: odeakin@apache.org [mailto:odeakin@apache.org]
> >>> Sent: Monday, March 17, 2008 9:18 PM
> >>> To: commits@harmony.apache.org
> >>> Subject: svn commit: r637937 - in
> >>> /harmony/enhanced/jdktools/trunk/modules/jpda: ./
> >>> src/main/native/jdwp/common/transport/common/
> >>> src/main/native/jdwp/unix/transport/
> >>> src/main/native/jdwp/unix/transport/dt_socket/
> >>> src/main/native/jdwp/windows/transport/ src/mai...
> >>>
> >>> Author: odeakin
> >>> Date: Mon Mar 17 08:17:35 2008
> >>> New Revision: 637937
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=637937&view=rev
> >>> Log:
> >>> Some changes to start implementation of JDWP shared memory transport:
> >>> - Reorganisation of socket transport makefiles into their own subdirectories.
> >>> - Initial check-in of shared memory transport code.
> >>> - Alteration to build.xml to start building dt_shmem.dll on Windows.
> >>>
> >>> Added:
> >>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/dt_socket/exports.txt
> >>> - copied unchanged from r636747,
> >>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/exports.txt
> >>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/dt_socket/makefile
> >>> - copied, changed from r636747,
> >>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/makefile
> >>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/
> >>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/SharedMemTransport.cpp
> >>> (with props)
> >>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/SharedMemTransport.h
> >>> (with props)
> >>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/dt_shmem.def
> >>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/makefile
> >>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_socket/makefile
> >>> - copied, changed from r636747,
> >>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/makefile
> >>> Removed:
> >>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/exports.txt
> >>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/makefile
> >>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/makefile
> >>> Modified:
> >>> harmony/enhanced/jdktools/trunk/modules/jpda/build.xml
> >>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/common/transport/common/LastTransportError.h
> >>>
> >>> Modified: harmony/enhanced/jdktools/trunk/modules/jpda/build.xml
> >>> URL: http://svn.apache.org/viewvc/harmony/enhanced/jdktools/trunk/modules/jpda/build.xml?rev=637937&r1=637936&r2=637937&view=diff
> >>> ==============================================================================
> >>>
> >>> <SNIP>
> >>>
> >>>
> >>>
> >> --
> >> Oliver Deakin
> >> Unless stated otherwise above:
> >> IBM United Kingdom Limited - Registered in England and Wales with number 741598.
> >> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
> >>
> >>
> >>
> >
> >
>
> --
> Oliver Deakin
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>
>
Re: svn commit: r637937 - in /harmony/enhanced/jdktools/trunk/modules/jpda:
....
Posted by Oliver Deakin <ol...@googlemail.com>.
Hi Stepan,
Thanks for fixing that! I did do a build on Linux at the time, but it
was a sequential build from an already existing workspace so it must
have missed that change somehow. Ill build from scratch next time to
make sure!
I do watch the alerts list, and I fixed the build break I saw (the one
you raised initially), but received no further mails indicating a break
on Linux x86. I take it a mail only gets sent when the state of the
build changes? So if there is a second break (as in this case) no mail
is sent because the build state does not change? I will keep my eye on
the integrity page from now on instead to make sure.
Regards,
Oliver
Stepan Mishura wrote:
> On 3/18/08, Oliver Deakin <ol...@googlemail.com> wrote:
>
>> Sorry about this - there was a missing "is.windows" check for the
>> dt_shmem clean target. Should be fixed at r638284.
>>
>>
>
> Unfortunately, this didn't fully fix the Linux build - the makefile
> also had to be adjusted (I fixed it at r638711).
>
> Oliver, if you don't have access to the Linux host why you don't use
> integrity status page [1] to check that your updates don't break
> anything? The page is updated regularly and it is possible to know
> effect of your changes in hours. Also there is an alerts list
> (alerts@harmony.apache.org). The list is used for alerts notifications
> for suites included into integrity testing. So if you were subscribed
> to the list, updated the build and get notification about broken build
> then that would mean that probably your changes broke the build.
>
> And the best way to avoid broken builds is to check changes before
> committing on both platforms :-)
>
> [1] http://people.apache.org/~varlax/harmony-integrity/
>
> Thanks,
> Stepan.
>
>
>> Regards,
>> Oliver
>>
>> Stepan Mishura wrote:
>>
>>> Hi Oliver,
>>>
>>> Your commit broke Linux build. Could you fix it or roll it back?
>>>
>>> The build fails with:
>>>
>>> [java] -clean-native-windows:
>>> [java] [echo] Making "clean" in
>>> /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/modules/jpda/src/main/native/jdwp/unix/transport/dt_shmem
>>> [java] [echo] LOCAL MAKE DEFN L
>>> /export/users/cc/cc-common/build/checkouts/hdk/working_vm/deploy
>>> [java]
>>> [java] BUILD FAILED
>>> [java] /export/users/cc/cc-common/build/checkouts/hdk/build.xml:444:
>>> The following error occurred while executing this line:
>>> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/build.xml:200:
>>> The following error occurred while executing this line:
>>> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/make/build-native.xml:69:
>>> The following error occurred while executing this line:
>>> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/make/properties.xml:336:
>>> The following error occurred while executing this line:
>>> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/modules/jpda/build.xml:185:
>>> The following error occurred while executing this line:
>>> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/modules/jpda/build.xml:189:
>>> The following error occurred while executing this line:
>>> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/make/properties.xml:354:
>>> The directory you specified does not exist
>>>
>>> Thanks,
>>> Stepan.
>>>
>>> -----Original Message-----
>>> From: odeakin@apache.org [mailto:odeakin@apache.org]
>>> Sent: Monday, March 17, 2008 9:18 PM
>>> To: commits@harmony.apache.org
>>> Subject: svn commit: r637937 - in
>>> /harmony/enhanced/jdktools/trunk/modules/jpda: ./
>>> src/main/native/jdwp/common/transport/common/
>>> src/main/native/jdwp/unix/transport/
>>> src/main/native/jdwp/unix/transport/dt_socket/
>>> src/main/native/jdwp/windows/transport/ src/mai...
>>>
>>> Author: odeakin
>>> Date: Mon Mar 17 08:17:35 2008
>>> New Revision: 637937
>>>
>>> URL: http://svn.apache.org/viewvc?rev=637937&view=rev
>>> Log:
>>> Some changes to start implementation of JDWP shared memory transport:
>>> - Reorganisation of socket transport makefiles into their own subdirectories.
>>> - Initial check-in of shared memory transport code.
>>> - Alteration to build.xml to start building dt_shmem.dll on Windows.
>>>
>>> Added:
>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/dt_socket/exports.txt
>>> - copied unchanged from r636747,
>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/exports.txt
>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/dt_socket/makefile
>>> - copied, changed from r636747,
>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/makefile
>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/
>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/SharedMemTransport.cpp
>>> (with props)
>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/SharedMemTransport.h
>>> (with props)
>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/dt_shmem.def
>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/makefile
>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_socket/makefile
>>> - copied, changed from r636747,
>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/makefile
>>> Removed:
>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/exports.txt
>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/makefile
>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/makefile
>>> Modified:
>>> harmony/enhanced/jdktools/trunk/modules/jpda/build.xml
>>> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/common/transport/common/LastTransportError.h
>>>
>>> Modified: harmony/enhanced/jdktools/trunk/modules/jpda/build.xml
>>> URL: http://svn.apache.org/viewvc/harmony/enhanced/jdktools/trunk/modules/jpda/build.xml?rev=637937&r1=637936&r2=637937&view=diff
>>> ==============================================================================
>>>
>>> <SNIP>
>>>
>>>
>>>
>> --
>> Oliver Deakin
>> Unless stated otherwise above:
>> IBM United Kingdom Limited - Registered in England and Wales with number 741598.
>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>>
>>
>>
>
>
--
Oliver Deakin
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
Re: svn commit: r637937 - in /harmony/enhanced/jdktools/trunk/modules/jpda: ....
Posted by Stepan Mishura <st...@gmail.com>.
On 3/18/08, Oliver Deakin <ol...@googlemail.com> wrote:
> Sorry about this - there was a missing "is.windows" check for the
> dt_shmem clean target. Should be fixed at r638284.
>
Unfortunately, this didn't fully fix the Linux build - the makefile
also had to be adjusted (I fixed it at r638711).
Oliver, if you don't have access to the Linux host why you don't use
integrity status page [1] to check that your updates don't break
anything? The page is updated regularly and it is possible to know
effect of your changes in hours. Also there is an alerts list
(alerts@harmony.apache.org). The list is used for alerts notifications
for suites included into integrity testing. So if you were subscribed
to the list, updated the build and get notification about broken build
then that would mean that probably your changes broke the build.
And the best way to avoid broken builds is to check changes before
committing on both platforms :-)
[1] http://people.apache.org/~varlax/harmony-integrity/
Thanks,
Stepan.
> Regards,
> Oliver
>
> Stepan Mishura wrote:
> > Hi Oliver,
> >
> > Your commit broke Linux build. Could you fix it or roll it back?
> >
> > The build fails with:
> >
> > [java] -clean-native-windows:
> > [java] [echo] Making "clean" in
> > /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/modules/jpda/src/main/native/jdwp/unix/transport/dt_shmem
> > [java] [echo] LOCAL MAKE DEFN L
> > /export/users/cc/cc-common/build/checkouts/hdk/working_vm/deploy
> > [java]
> > [java] BUILD FAILED
> > [java] /export/users/cc/cc-common/build/checkouts/hdk/build.xml:444:
> > The following error occurred while executing this line:
> > [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/build.xml:200:
> > The following error occurred while executing this line:
> > [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/make/build-native.xml:69:
> > The following error occurred while executing this line:
> > [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/make/properties.xml:336:
> > The following error occurred while executing this line:
> > [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/modules/jpda/build.xml:185:
> > The following error occurred while executing this line:
> > [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/modules/jpda/build.xml:189:
> > The following error occurred while executing this line:
> > [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/make/properties.xml:354:
> > The directory you specified does not exist
> >
> > Thanks,
> > Stepan.
> >
> > -----Original Message-----
> > From: odeakin@apache.org [mailto:odeakin@apache.org]
> > Sent: Monday, March 17, 2008 9:18 PM
> > To: commits@harmony.apache.org
> > Subject: svn commit: r637937 - in
> > /harmony/enhanced/jdktools/trunk/modules/jpda: ./
> > src/main/native/jdwp/common/transport/common/
> > src/main/native/jdwp/unix/transport/
> > src/main/native/jdwp/unix/transport/dt_socket/
> > src/main/native/jdwp/windows/transport/ src/mai...
> >
> > Author: odeakin
> > Date: Mon Mar 17 08:17:35 2008
> > New Revision: 637937
> >
> > URL: http://svn.apache.org/viewvc?rev=637937&view=rev
> > Log:
> > Some changes to start implementation of JDWP shared memory transport:
> > - Reorganisation of socket transport makefiles into their own subdirectories.
> > - Initial check-in of shared memory transport code.
> > - Alteration to build.xml to start building dt_shmem.dll on Windows.
> >
> > Added:
> > harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/dt_socket/exports.txt
> > - copied unchanged from r636747,
> > harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/exports.txt
> > harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/dt_socket/makefile
> > - copied, changed from r636747,
> > harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/makefile
> > harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/
> > harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/SharedMemTransport.cpp
> > (with props)
> > harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/SharedMemTransport.h
> > (with props)
> > harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/dt_shmem.def
> > harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/makefile
> > harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_socket/makefile
> > - copied, changed from r636747,
> > harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/makefile
> > Removed:
> > harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/exports.txt
> > harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/makefile
> > harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/makefile
> > Modified:
> > harmony/enhanced/jdktools/trunk/modules/jpda/build.xml
> > harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/common/transport/common/LastTransportError.h
> >
> > Modified: harmony/enhanced/jdktools/trunk/modules/jpda/build.xml
> > URL: http://svn.apache.org/viewvc/harmony/enhanced/jdktools/trunk/modules/jpda/build.xml?rev=637937&r1=637936&r2=637937&view=diff
> > ==============================================================================
> >
> > <SNIP>
> >
> >
>
> --
> Oliver Deakin
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>
>
Re: svn commit: r637937 - in /harmony/enhanced/jdktools/trunk/modules/jpda:
....
Posted by Oliver Deakin <ol...@googlemail.com>.
Sorry about this - there was a missing "is.windows" check for the
dt_shmem clean target. Should be fixed at r638284.
Regards,
Oliver
Stepan Mishura wrote:
> Hi Oliver,
>
> Your commit broke Linux build. Could you fix it or roll it back?
>
> The build fails with:
>
> [java] -clean-native-windows:
> [java] [echo] Making "clean" in
> /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/modules/jpda/src/main/native/jdwp/unix/transport/dt_shmem
> [java] [echo] LOCAL MAKE DEFN L
> /export/users/cc/cc-common/build/checkouts/hdk/working_vm/deploy
> [java]
> [java] BUILD FAILED
> [java] /export/users/cc/cc-common/build/checkouts/hdk/build.xml:444:
> The following error occurred while executing this line:
> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/build.xml:200:
> The following error occurred while executing this line:
> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/make/build-native.xml:69:
> The following error occurred while executing this line:
> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/make/properties.xml:336:
> The following error occurred while executing this line:
> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/modules/jpda/build.xml:185:
> The following error occurred while executing this line:
> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/modules/jpda/build.xml:189:
> The following error occurred while executing this line:
> [java] /export/users/cc/cc-common/build/checkouts/hdk/working_jdktools/make/properties.xml:354:
> The directory you specified does not exist
>
> Thanks,
> Stepan.
>
> -----Original Message-----
> From: odeakin@apache.org [mailto:odeakin@apache.org]
> Sent: Monday, March 17, 2008 9:18 PM
> To: commits@harmony.apache.org
> Subject: svn commit: r637937 - in
> /harmony/enhanced/jdktools/trunk/modules/jpda: ./
> src/main/native/jdwp/common/transport/common/
> src/main/native/jdwp/unix/transport/
> src/main/native/jdwp/unix/transport/dt_socket/
> src/main/native/jdwp/windows/transport/ src/mai...
>
> Author: odeakin
> Date: Mon Mar 17 08:17:35 2008
> New Revision: 637937
>
> URL: http://svn.apache.org/viewvc?rev=637937&view=rev
> Log:
> Some changes to start implementation of JDWP shared memory transport:
> - Reorganisation of socket transport makefiles into their own subdirectories.
> - Initial check-in of shared memory transport code.
> - Alteration to build.xml to start building dt_shmem.dll on Windows.
>
> Added:
> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/dt_socket/exports.txt
> - copied unchanged from r636747,
> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/exports.txt
> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/dt_socket/makefile
> - copied, changed from r636747,
> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/makefile
> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/
> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/SharedMemTransport.cpp
> (with props)
> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/SharedMemTransport.h
> (with props)
> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/dt_shmem.def
> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/makefile
> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/dt_socket/makefile
> - copied, changed from r636747,
> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/makefile
> Removed:
> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/exports.txt
> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/unix/transport/makefile
> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/windows/transport/makefile
> Modified:
> harmony/enhanced/jdktools/trunk/modules/jpda/build.xml
> harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/common/transport/common/LastTransportError.h
>
> Modified: harmony/enhanced/jdktools/trunk/modules/jpda/build.xml
> URL: http://svn.apache.org/viewvc/harmony/enhanced/jdktools/trunk/modules/jpda/build.xml?rev=637937&r1=637936&r2=637937&view=diff
> ==============================================================================
>
> <SNIP>
>
>
--
Oliver Deakin
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU