You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/12 05:59:00 UTC

[GitHub] [kafka] showuon opened a new pull request #10118: KAFKA-10192: increase starting up waiting time

showuon opened a new pull request #10118:
URL: https://github.com/apache/kafka/pull/10118


   Recently, we saw some errors:
   
   `org.opentest4j.AssertionFailedError: Condition not met within timeout 30000. Worker did not complete startup in time ==> expected: <true> but was: <false>`
   
   And after some tests, I confirmed this is just because the slow system, not other issues. What I did is trying to wait 2 times, to see if we failed at 1st time, and passed at 2nd. And after testing in jenkins build, the errors are showing: **failed 1st, but passed in 2nd try**. So, we can just increase the waiting time to fix these flaky tests.
   
   ```java
           boolean fail = false;
           try {
               waitForCondition(
                   () -> connect.requestGet(connect.endpointForResource("connectors/nonexistent")).getStatus() == 404,
                   CONNECT_WORKER_STARTUP_TIMEOUT,
                   "Worker did not complete startup in time"
               );
           } catch (final java.lang.AssertionError e) {
               fail = true;
           }
   
   
           waitForCondition(
               () -> connect.requestGet(connect.endpointForResource("connectors/nonexistent")).getStatus() == 404,
                 CONNECT_WORKER_STARTUP_TIMEOUT
                 "Worker did not complete startup in time"
           );     
           if (fail) {
               fail("failed 1st, but passed in 2nd try");
           }
   ```
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] rhauch merged pull request #10118: KAFKA-10192: Increase max time to wait for worker to start in some integration tests

Posted by GitBox <gi...@apache.org>.
rhauch merged pull request #10118:
URL: https://github.com/apache/kafka/pull/10118


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon edited a comment on pull request #10118: KAFKA-10192: increase starting up waiting time

Posted by GitBox <gi...@apache.org>.
showuon edited a comment on pull request #10118:
URL: https://github.com/apache/kafka/pull/10118#issuecomment-781768574


   > Fine by me, flaky tests suck. 
   
   Indeed! Thanks, @C0urante 
   
   @kkonstantine , could you check this PR? Thanks.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #10118: KAFKA-10192: increase starting up waiting time

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10118:
URL: https://github.com/apache/kafka/pull/10118#issuecomment-777994389


   @C0urante @kkonstantine , could you help review this simple PR? Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #10118: KAFKA-10192: increase starting up waiting time

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10118:
URL: https://github.com/apache/kafka/pull/10118#issuecomment-793916620


   @kkonstantine @rhauch  , could you help review this PR? Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #10118: KAFKA-10192: increase starting up waiting time

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10118:
URL: https://github.com/apache/kafka/pull/10118#issuecomment-781768574


   > Fine by me, flaky tests suck. 
   Indeed! Thanks, @C0urante 
   
   @kkonstantine , could you check this PR? Thanks.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org