You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by apsaltis <gi...@git.apache.org> on 2016/07/10 17:08:19 UTC
[GitHub] nifi pull request #625: NIFI-2214 updated both of the Azure Event Hub proces...
GitHub user apsaltis opened a pull request:
https://github.com/apache/nifi/pull/625
NIFI-2214 updated both of the Azure Event Hub processors to use latest Azure Event Hub client
NIFI-2214 updated the both of the Azure Event Hub processors to use the latest Azure Event Hub libraries. Also added test cases for each of the processors
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apsaltis/nifi nifi-2214
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/625.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #625
----
commit d586455aba988abea8edf707fc07cc593c876ffa
Author: Andrew Psaltis <ps...@gmail.com>
Date: 2016-07-10T17:00:56Z
NIFI-2214 updated the both of the Azure Event Hub processors to use the latest Azure Event Hub libraries. Also added test cases for each of the processors
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #625: NIFI-2214 updated both of the Azure Event Hub proces...
Posted by apsaltis <gi...@git.apache.org>.
Github user apsaltis closed the pull request at:
https://github.com/apache/nifi/pull/625
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #625: NIFI-2214 updated both of the Azure Event Hub processors to...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/625
@apsaltis can you please close this out as Mark references that it is merged. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #625: NIFI-2214 updated both of the Azure Event Hub processors to...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/625
@apsaltis great, thanks! The MIT licenses are handled a little differently and are placed in the LICENSE file instead of the NOTICE file. I updated accordingly and pushed to master. Thanks for jumping in and fixing this issue! Unfortunately, I'm noticing now that i forgot the magical incantation to close the PR. Can you close it manually? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #625: NIFI-2214 updated both of the Azure Event Hub processors to...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/625
@apsaltis very cool that you were able to jump in and knock this out! The community very much appreciates it! Looking through the code, it all looks good. I did notice though that the client library was changed, and the licensing information was not updated. Need to be sure that the NOTICE file in both the nar's src/main/resources directory as well as the nifi-assembly's NOTICE file. The previous client used an ASF 2.0 license, and the new one uses an MIT license.
Also, I did notice that the Put could be more efficient by sending several events asynchronously and then waiting on the ACK's to come back. I created a new JIRA for this though (https://issues.apache.org/jira/browse/NIFI-2220) because it's not necessarily critical to get that into this PR.
If you can update the LICENSE info, then I should be able to get this merged in.
Thanks again for knocking this out!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---