You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/07 06:23:41 UTC

[GitHub] [flink] xccui opened a new pull request #13974: [hotfix][doc] Fix a concurrent issue in testing.md

xccui opened a new pull request #13974:
URL: https://github.com/apache/flink/pull/13974


   ## What is the purpose of the change
   
   An example in `testing.md` uses `synchronized` keyword to protect a static variable, which will cause concurrent issues with multiple sink instances. 
   
   ## Brief change log
   
   Use `Collections.synchronizedList()` to create a thread-safe list and remove the old `synchronized` keyword.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   This change added tests and can be verified as follows:
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] knaufk merged pull request #13974: [hotfix][doc] Fix a concurrent issue in testing.md

Posted by GitBox <gi...@apache.org>.
knaufk merged pull request #13974:
URL: https://github.com/apache/flink/pull/13974


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] xccui commented on pull request #13974: [hotfix][doc] Fix a concurrent issue in testing.md

Posted by GitBox <gi...@apache.org>.
xccui commented on pull request #13974:
URL: https://github.com/apache/flink/pull/13974#issuecomment-725765326


   I've done that 😊


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13974: [hotfix][doc] Fix a concurrent issue in testing.md

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13974:
URL: https://github.com/apache/flink/pull/13974#issuecomment-723401121


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0073a428d1b41297708cbd146482e1d8509174cd",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9243",
       "triggerID" : "0073a428d1b41297708cbd146482e1d8509174cd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0073a428d1b41297708cbd146482e1d8509174cd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9243) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13974: [hotfix][doc] Fix a concurrent issue in testing.md

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13974:
URL: https://github.com/apache/flink/pull/13974#issuecomment-723399501


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 0073a428d1b41297708cbd146482e1d8509174cd (Sat Nov 07 06:26:06 UTC 2020)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13974: [hotfix][doc] Fix a concurrent issue in testing.md

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13974:
URL: https://github.com/apache/flink/pull/13974#issuecomment-723401121


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0073a428d1b41297708cbd146482e1d8509174cd",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9243",
       "triggerID" : "0073a428d1b41297708cbd146482e1d8509174cd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0073a428d1b41297708cbd146482e1d8509174cd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9243) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13974: [hotfix][doc] Fix a concurrent issue in testing.md

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13974:
URL: https://github.com/apache/flink/pull/13974#issuecomment-723401121


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0073a428d1b41297708cbd146482e1d8509174cd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0073a428d1b41297708cbd146482e1d8509174cd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0073a428d1b41297708cbd146482e1d8509174cd UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org