You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/22 09:20:04 UTC
[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #4887:
Review pagination SQL tests of Oracle
tristaZero opened a new issue #4887: Review pagination SQL tests of Oracle
URL: https://github.com/apache/incubator-shardingsphere/issues/4887
Content: After #4885 is fixed, this issue begins to process.
Difficulty Rating: ★★☆☆☆
### How to fix this one?
- [ ] Remove the comments from all `pagination` SQLs of Oracle in `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dml/select-pagination.xml` and `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dml/select-pagination-group-by-order-by.xml`
- [ ] Run `SQLParserParameterizedTest` to find targets to fix
- [ ] Modify the parsing results of those sql cases to make `SQLParserParameterizedTest ` pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4887:
Review pagination SQL tests of Oracle
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4887: Review pagination SQL tests of Oracle
URL: https://github.com/apache/incubator-shardingsphere/issues/4887#issuecomment-602170018
This issue has a prerequisite issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4887:
Review pagination SQL tests of Oracle
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4887: Review pagination SQL tests of Oracle
URL: https://github.com/apache/incubator-shardingsphere/issues/4887#issuecomment-608212160
@jingshanglu Hi could you take charge of this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services