You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alexandr Antonenko <hi...@gmail.com> on 2014/05/23 13:56:16 UTC

Review Request 21856: Add unit tests for views/*.js files

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21856/
-----------------------------------------------------------

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-5867
    https://issues.apache.org/jira/browse/AMBARI-5867


Repository: ambari


Description
-------

Add unit tests for views/*.js files


Diffs
-----

  ambari-web/app/assets/test/tests.js 2db199d 
  ambari-web/app/views/experimental.js 5d84c2c 
  ambari-web/test/views/application_test.js PRE-CREATION 
  ambari-web/test/views/experimental_test.js PRE-CREATION 
  ambari-web/test/views/installer_test.js PRE-CREATION 
  ambari-web/test/views/login_test.js PRE-CREATION 

Diff: https://reviews.apache.org/r/21856/diff/


Testing
-------


Thanks,

Alexandr Antonenko

Re: Review Request 21856: Add unit tests for views/*.js files

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21856/#review43823
-----------------------------------------------------------

Ship it!


Ship It!

- Aleksandr Kovalenko


On May 23, 2014, 11:56 a.m., Alexandr Antonenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21856/
> -----------------------------------------------------------
> 
> (Updated May 23, 2014, 11:56 a.m.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-5867
>     https://issues.apache.org/jira/browse/AMBARI-5867
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add unit tests for views/*.js files
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js 2db199d 
>   ambari-web/app/views/experimental.js 5d84c2c 
>   ambari-web/test/views/application_test.js PRE-CREATION 
>   ambari-web/test/views/experimental_test.js PRE-CREATION 
>   ambari-web/test/views/installer_test.js PRE-CREATION 
>   ambari-web/test/views/login_test.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21856/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexandr Antonenko
> 
>