[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5064: Sorting Traffic Ops GET /api/*/cdns alphabetically

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #5064:
URL: https://github.com/apache/trafficcontrol/pull/5064#discussion_r497660887



##########
File path: traffic_ops/traffic_ops_golang/cdn/cdns.go
##########
@@ -136,6 +137,8 @@ func (cdn *TOCDN) Read(h http.Header, useIMS bool) ([]interface{}, error, error,
 	// sorting alphabetically by cdn name.
 	if _, ok := cdn.APIInfo().Params["orderby"]; !ok {
 		cdn.APIInfo().Params["orderby"] = "name"
+	} else {
+		return nil, fmt.Errorf("unable to sort the list"), nil, http.StatusInternalServerError, nil

Review comment:
       Doesn't this mean that if I try to set `orderby` myself in the URL it'll give me back an internal server error?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org