You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/10/27 23:29:30 UTC

[GitHub] [geode-benchmarks] ezoerner opened a new pull request #159: GEODE-9291 sorted set benchmarks - more benchmarks

ezoerner opened a new pull request #159:
URL: https://github.com/apache/geode-benchmarks/pull/159


   Added benchmarks for ZRANGEBYSCORE, and a weighted benchmark for ZADD and ZRANGE.
   
   Tested with validation turned on.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode-benchmarks] DonalEvans commented on a change in pull request #159: GEODE-9291 sorted set benchmarks - more benchmarks

Posted by GitBox <gi...@apache.org>.
DonalEvans commented on a change in pull request #159:
URL: https://github.com/apache/geode-benchmarks/pull/159#discussion_r738705681



##########
File path: geode-benchmarks/src/main/java/org/apache/geode/benchmark/redis/tests/RedisWeightedZaddAndZrangeBenchmark.java
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.geode.benchmark.redis.tests;
+
+import static org.apache.geode.benchmark.Config.before;
+import static org.apache.geode.benchmark.Config.workload;
+import static org.apache.geode.benchmark.topology.Roles.CLIENT;
+
+import org.apache.geode.benchmark.redis.tasks.PrePopulateRedisHash;
+import org.apache.geode.benchmark.redis.tasks.ZaddRedisTask;
+import org.apache.geode.benchmark.redis.tasks.ZrangeRedisTask;
+import org.apache.geode.benchmark.tasks.WeightedTasks;
+import org.apache.geode.benchmark.tasks.WeightedTasks.WeightedTask;
+import org.apache.geode.perftest.TestConfig;
+
+public class RedisWeightedZaddAndZrangeBenchmark extends RedisBenchmark {
+
+  @Override
+  public TestConfig configure() {
+    final TestConfig config = super.configure();
+
+    before(config, new PrePopulateRedisHash(redisClientManager, keyRange), CLIENT);

Review comment:
       I think this should be `PrePopulateRedisSortedSet()`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode-benchmarks] DonalEvans merged pull request #159: GEODE-9291 sorted set benchmarks - more benchmarks

Posted by GitBox <gi...@apache.org>.
DonalEvans merged pull request #159:
URL: https://github.com/apache/geode-benchmarks/pull/159


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode-benchmarks] ezoerner commented on pull request #159: GEODE-9291 sorted set benchmarks - more benchmarks

Posted by GitBox <gi...@apache.org>.
ezoerner commented on pull request #159:
URL: https://github.com/apache/geode-benchmarks/pull/159#issuecomment-954125324


   Looks like I need to clean up some code for spotlessJava...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode-benchmarks] ezoerner removed a comment on pull request #159: GEODE-9291 sorted set benchmarks - more benchmarks

Posted by GitBox <gi...@apache.org>.
ezoerner removed a comment on pull request #159:
URL: https://github.com/apache/geode-benchmarks/pull/159#issuecomment-954125324


   Looks like I need to clean up some code for spotlessJava...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org