[jira] [Commented] (OAK-4657) Add metric for FileStore cleanup reclaimed size

["Michael Dürig (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415015#comment-15415015 ] 

Michael Dürig commented on OAK-4657:
------------------------------------

I like this statistics being exposed. But I'm not sure whether {{FileStoreStatsMBean}} is the right place. There is also {{GCMonitorMBean}} and OAK-4293 to that respect. 

Also exposing gc related data through time series didn't work well in the past. People usually wanted to get the reclaimed bytes / repository size from the last gc cycle. Parsing this out of the time series turned out to be hard. 

Finally [~alex.parvulescu] introduced the gc journal with OAK-4293. Would it make sense to make the reclaimed size also part of that one? 

> Add metric for FileStore cleanup reclaimed size
> -----------------------------------------------
>
>                 Key: OAK-4657
>                 URL: https://issues.apache.org/jira/browse/OAK-4657
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>    Affects Versions: Segment Tar 0.0.10
>            Reporter: Andrei Dulceanu
>            Assignee: Andrei Dulceanu
>            Priority: Minor
>         Attachments: OAK-4657-01.patch
>
>
> It would be good to have a metric to capture the number of bytes actually removed from disk after each cleanup cycle. Looking at repository size before/after cleanup can be misleading as concurrent writes can happen in between. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)