[jira] [Commented] (HBASE-17575) Run critical tests with each of the Inmemory Compaction Policies enabled (Towards Making BASIC the Default In-Memory Compaction Policy)

["Eshcar Hillel (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-17575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853211#comment-15853211 ] 

Eshcar Hillel commented on HBASE-17575:
---------------------------------------

Thanks [~stack] -- the new title is definitely better :)

bq. This change is interesting: 57	scanners.add(segment.getScanner(Integer.MAX_VALUE)); We are doing 'dirty reads'?
No dirty reads since these scanners are currently only used by the compacting scanner which is a store scanner that uses SQM to get the right results.

bq. No mslab? Or is that later?
No mslab, just like in the benchmarks. Also to reduce the chance of out-of-memory exception.


> Run critical tests with each of the Inmemory Compaction Policies enabled (Towards Making BASIC the Default In-Memory Compaction Policy)
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-17575
>                 URL: https://issues.apache.org/jira/browse/HBASE-17575
>             Project: HBase
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Eshcar Hillel
>            Assignee: Eshcar Hillel
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17575-V01.patch, HBASE-17575-V01.patch
>
>
> In preparation for switching the default in-memory compaction policy to BASIC, we would like to make sure that once we do the switch all tests will run (and pass!) with the new default policy.
> To this end, we remove the NONE configuration setting added to tests in HBASE-17294 and HBASE-17316.
> We verified these tests pass with all 3 memory compaction policies.
> For each test 
> (1) if all 3 policies pass the test -- we remove the configuration from the test.
> (2) if some fail we add tests of all 3 configurations, e.g., by parameterized tests. When needed we update expected results.
> One test failure identified a small bug which is also fixed in the patch.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)