You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@celix.apache.org by ESmink <gi...@git.apache.org> on 2017/11/15 14:45:08 UTC

[GitHub] celix-site pull request #2: Added files for new serverbuilder + content

GitHub user ESmink opened a pull request:

    https://github.com/apache/celix-site/pull/2

    Added files for new serverbuilder + content

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ESmink/celix-site asf-site

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/celix-site/pull/2.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2
    
----
commit 64acc208f4170a35fb6dc19cbc9531935fcdf280
Author: maintain <ma...@localhost.localdomain>
Date:   2017-11-15T14:39:07Z

    added current files for the new website

commit 83d462c77912a1753c7b02be1e53b7d4def08863
Author: maintain <ma...@localhost.localdomain>
Date:   2017-11-15T14:43:34Z

    small fix readme

----


---

[GitHub] celix-site pull request #2: Added files for new serverbuilder + content

Posted by ESmink <gi...@git.apache.org>.

Github user ESmink closed the pull request at:

    https://github.com/apache/celix-site/pull/2


---

[GitHub] celix-site issue #2: Added files for new serverbuilder + content

Posted by pnoltes <gi...@git.apache.org>.

Github user pnoltes commented on the issue:

    https://github.com/apache/celix-site/pull/2
  
    Hi Edwin,
    
    Could update and create a new pull request and first configure git with a correct user. Currently the commits have the author: maintain <ma...@localhost.localdomain>
    
    I would prefer your actual name and email. see 
    https://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup
    
    Greetings,
    Pepijn 


---

[GitHub] celix-site issue #2: Added files for new serverbuilder + content

Posted by rlenferink <gi...@git.apache.org>.

Github user rlenferink commented on the issue:

    https://github.com/apache/celix-site/pull/2
  
    Hi Edwin,
    
    The quotes around the sourcecode directory are problematic when performing a git clone on windows. Using git bash results in: `fatal: cannot create directory at 'celix/documentation/"sourcecode"': Invalid argument`.
    
    Can you rename the directory so it doesn't contain any quotes.
    
    Thanks,
    Roy


---