You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by liuyuzhong <gi...@git.apache.org> on 2016/09/01 07:25:31 UTC
[GitHub] flink pull request #2452: Flink-4450 add a new module "flink-apache-storm" t...
GitHub user liuyuzhong opened a pull request:
https://github.com/apache/flink/pull/2452
Flink-4450 add a new module "flink-apache-storm" to support new storm verion(higher than 1.0.0)
@StephanEwen
1. Create new module "flink-apache-storm" copy from flink-contrib/flink-storm, It support compatibility layer for storm which higher than 1.0.0.
2. Create new module "flink-apache-storm-examples" copy from flink-contrib/flink-storm-examples, given the examples for storm program which version than 1.0.0
3. mvn clean verify: ok
4. Test: ok
- run new storm example
```
bin/flink run flink/flink-contrib/flink-apache-storm-examples/target/WordCount-StormTopology.jar
bin/flink run flink/flink-contrib/flink-apache-storm-examples/target/WordCount-BoltTokenizer.jar
bin/flink run flink/flink-contrib/flink-apache-storm-examples/target/WordCount-SpoutSource.jar
```
- run old storm example:
```
bin/flink run flink/flink-contrib/flink-storm-examples/target/WordCount-StormTopology.jar
bin/flink run flink/flink-contrib/flink-storm-examples/target/WordCount-BoltTokenizer.jar
bin/flink run flink/flink-contrib/flink-storm-examples/target/WordCount-SpoutSource.jar
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liuyuzhong/flink FLINK-4450
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2452.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2452
----
commit eeb1fc284d6879404b05eab422ed898a9440cdb5
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-08-29T11:03:15Z
#4450 update storm version to 1.0.0
commit 055743ad65c6213e8fe8d422e929e795c3bad8f1
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-08-30T06:05:08Z
#4450 update storm version to 1.0.0 in flink-storm-examples
commit 409827d8e7ac69743b9c7f98774c001f6551457c
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-08-30T06:10:47Z
#4450 reverse for uncorrect change submit pom.xml
commit eebd8c534933fb2639dc248469ba56a2ed053cb7
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-08-30T06:12:00Z
#4450 reverse for uncorrect change submit pom.xml
commit 8788b0eb2146f3a7bb3d0af2ae61cabc7741f6bf
Author: liuyuzhong <da...@qq.com>
Date: 2016-08-30T06:14:44Z
Merge pull request #1 from liuyuzhong/4450
#4450 update storm version to 1.0.0
commit 89d04437c74567fe21949f0b3ac5730e42002db2
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-08-31T03:12:14Z
#4450 exclusion unnecessary dependency in flink-storm
commit 3a20d1957a986daa0eb4758d701cd9cd0ac98839
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-08-31T03:14:21Z
#4450 delete LocalCluster storm topology test
commit 5765f2d51e6e84d82f2697d2c7ad7656ca8708c1
Author: liuyuzhong <da...@qq.com>
Date: 2016-08-31T03:26:21Z
Merge pull request #2 from liuyuzhong/4450
4450
commit 33bd4f377074cd680299891a97734cd8658b4129
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-09-01T04:58:56Z
#4450 sync to https://github.com/apache/flink.git
commit 3be5a1b1ec12ffb22eea5695c51723129d566a98
Author: liuyuzhong <da...@qq.com>
Date: 2016-09-01T05:02:14Z
Merge pull request #3 from liuyuzhong/4450
#4450 sync to https://github.com/apache/flink.git
commit a0dfde6b70fe5c12bee0a9257cfa0c3a1bb19fac
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-09-01T05:32:43Z
sync to https://github.com/apache/flink.git
commit 3afe545558295e7284974d157d56be4d8829510b
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-09-01T05:33:11Z
Merge branch 'FLINK-4450'
commit 84f951dfe424a8867454a7b6196abd33d6c4207c
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-09-01T06:12:04Z
FLINK-4450 campable old storm version
commit da783f415d29b503b351d12ed7ada48c5ea1b953
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-09-01T07:10:08Z
FLINK-4450 campable for apache storm which version higher than 1.0.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2452
@liuyuzhong Try rebasing on the latest master, should be fixed with https://issues.apache.org/jira/browse/FLINK-4570
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2452
Agreed, let's proceed with #2439. Sorry for the back and forth, but these things are important to discuss so that everyone is on board and we make a good decision.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2452: Flink-4450 add a new module "flink-apache-storm" to suppo...
Posted by liuyuzhong <gi...@git.apache.org>.
Github user liuyuzhong commented on the issue:
https://github.com/apache/flink/pull/2452
flink-apache-storm copy from flink-storm, and update storm version to 1.0.0
flink-apache-storm-examples copy from flink-storm-examples, and update storm version to 1.0.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2452: [Flink-4450] add a new module "flink-apache-storm"...
Posted by liuyuzhong <gi...@git.apache.org>.
Github user liuyuzhong closed the pull request at:
https://github.com/apache/flink/pull/2452
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Posted by liuyuzhong <gi...@git.apache.org>.
Github user liuyuzhong commented on the issue:
https://github.com/apache/flink/pull/2452
OK, how about reopen pull requests #2439 ? Just update storm version to 1.0, and it can support storm 1.0+ version program.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2452: [Flink-4450] add a new module "flink-apache-storm"...
Posted by liuyuzhong <gi...@git.apache.org>.
Github user liuyuzhong closed the pull request at:
https://github.com/apache/flink/pull/2452
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2452: [Flink-4450] add a new module "flink-apache-storm"...
Posted by liuyuzhong <gi...@git.apache.org>.
GitHub user liuyuzhong reopened a pull request:
https://github.com/apache/flink/pull/2452
[Flink-4450] add a new module "flink-apache-storm" to support new storm verion program (higher than 1.0.0)
@StephanEwen
1. Create new module "flink-apache-storm" copy from flink-contrib/flink-storm, It support compatibility layer for storm which higher than 1.0.0.
2. Create new module "flink-apache-storm-examples" copy from flink-contrib/flink-storm-examples, given the examples for storm program which version higher than 1.0.0
3. mvn clean verify: ok
4. Test: ok
- run new storm example
```
bin/flink run flink/flink-contrib/flink-apache-storm-examples/target/WordCount-StormTopology.jar
bin/flink run flink/flink-contrib/flink-apache-storm-examples/target/WordCount-BoltTokenizer.jar
bin/flink run flink/flink-contrib/flink-apache-storm-examples/target/WordCount-SpoutSource.jar
```
- run old storm example:
```
bin/flink run flink/flink-contrib/flink-storm-examples/target/WordCount-StormTopology.jar
bin/flink run flink/flink-contrib/flink-storm-examples/target/WordCount-BoltTokenizer.jar
bin/flink run flink/flink-contrib/flink-storm-examples/target/WordCount-SpoutSource.jar
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liuyuzhong/flink FLINK-4450
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2452.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2452
----
commit eeb1fc284d6879404b05eab422ed898a9440cdb5
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-08-29T11:03:15Z
#4450 update storm version to 1.0.0
commit 055743ad65c6213e8fe8d422e929e795c3bad8f1
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-08-30T06:05:08Z
#4450 update storm version to 1.0.0 in flink-storm-examples
commit 409827d8e7ac69743b9c7f98774c001f6551457c
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-08-30T06:10:47Z
#4450 reverse for uncorrect change submit pom.xml
commit eebd8c534933fb2639dc248469ba56a2ed053cb7
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-08-30T06:12:00Z
#4450 reverse for uncorrect change submit pom.xml
commit 8788b0eb2146f3a7bb3d0af2ae61cabc7741f6bf
Author: liuyuzhong <da...@qq.com>
Date: 2016-08-30T06:14:44Z
Merge pull request #1 from liuyuzhong/4450
#4450 update storm version to 1.0.0
commit 89d04437c74567fe21949f0b3ac5730e42002db2
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-08-31T03:12:14Z
#4450 exclusion unnecessary dependency in flink-storm
commit 3a20d1957a986daa0eb4758d701cd9cd0ac98839
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-08-31T03:14:21Z
#4450 delete LocalCluster storm topology test
commit 5765f2d51e6e84d82f2697d2c7ad7656ca8708c1
Author: liuyuzhong <da...@qq.com>
Date: 2016-08-31T03:26:21Z
Merge pull request #2 from liuyuzhong/4450
4450
commit 33bd4f377074cd680299891a97734cd8658b4129
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-09-01T04:58:56Z
#4450 sync to https://github.com/apache/flink.git
commit 3be5a1b1ec12ffb22eea5695c51723129d566a98
Author: liuyuzhong <da...@qq.com>
Date: 2016-09-01T05:02:14Z
Merge pull request #3 from liuyuzhong/4450
#4450 sync to https://github.com/apache/flink.git
commit a0dfde6b70fe5c12bee0a9257cfa0c3a1bb19fac
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-09-01T05:32:43Z
sync to https://github.com/apache/flink.git
commit 3afe545558295e7284974d157d56be4d8829510b
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-09-01T05:33:11Z
Merge branch 'FLINK-4450'
commit 84f951dfe424a8867454a7b6196abd33d6c4207c
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-09-01T06:12:04Z
FLINK-4450 campable old storm version
commit da783f415d29b503b351d12ed7ada48c5ea1b953
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-09-01T07:10:08Z
FLINK-4450 campable for apache storm which version higher than 1.0.0
commit c8f63e7cfffc529c4c383ffebc01832b7c480bfa
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-09-05T02:02:56Z
Merge remote-tracking branch 'upstream/master'
commit 9544e967948dbddcee578e26e82f616f32cca1db
Author: yuzhongliu <yu...@tencent.com>
Date: 2016-09-05T02:14:09Z
Merge remote-tracking branch 'origin/master' into FLINK-4450
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2452: Flink-4450 add a new module "flink-apache-storm" to suppo...
Posted by liuyuzhong <gi...@git.apache.org>.
Github user liuyuzhong commented on the issue:
https://github.com/apache/flink/pull/2452
Jenkins run error:
```
error file=/home/jenkins/jenkins-slave/workspace/flink-github-ci/flink-mesos/src/test/scala/org/apache/flink/mesos/Utils.scala message=Expected identifier, but got Token(COMMA,,,1674,,)
Saving to outputFile=/home/jenkins/jenkins-slave/workspace/flink-github-ci/flink-mesos/target/scalastyle-output.xml
Processed 13 file(s)
Found 1 errors
Found 0 warnings
Found 0 infos
Finished in 209 ms
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] force-shading ...................................... SUCCESS [ 6.625 s]
[INFO] flink .............................................. SUCCESS [ 6.213 s]
[INFO] flink-annotations .................................. SUCCESS [ 4.565 s]
[INFO] flink-shaded-hadoop ................................ SUCCESS [ 1.079 s]
[INFO] flink-shaded-hadoop2 ............................... SUCCESS [ 27.133 s]
[INFO] flink-shaded-include-yarn-tests .................... SUCCESS [ 36.741 s]
[INFO] flink-shaded-curator ............................... SUCCESS [ 1.054 s]
[INFO] flink-shaded-curator-recipes ....................... SUCCESS [ 5.945 s]
[INFO] flink-shaded-curator-test .......................... SUCCESS [ 1.591 s]
[INFO] flink-metrics ...................................... SUCCESS [ 0.888 s]
[INFO] flink-metrics-core ................................. SUCCESS [ 5.857 s]
[INFO] flink-test-utils-parent ............................ SUCCESS [ 1.691 s]
[INFO] flink-test-utils-junit ............................. SUCCESS [ 19.417 s]
[INFO] flink-core ......................................... SUCCESS [01:21 min]
[INFO] flink-java ......................................... SUCCESS [01:03 min]
[INFO] flink-runtime ...................................... SUCCESS [08:49 min]
[INFO] flink-optimizer .................................... SUCCESS [ 28.185 s]
[INFO] flink-clients ...................................... SUCCESS [ 15.102 s]
[INFO] flink-streaming-java ............................... SUCCESS [ 57.792 s]
[INFO] flink-test-utils ................................... SUCCESS [ 17.591 s]
[INFO] flink-scala ........................................ SUCCESS [01:14 min]
[INFO] flink-runtime-web .................................. SUCCESS [ 32.911 s]
[INFO] flink-examples ..................................... SUCCESS [ 1.822 s]
[INFO] flink-examples-batch ............................... SUCCESS [ 31.045 s]
[INFO] flink-batch-connectors ............................. SUCCESS [ 1.693 s]
[INFO] flink-hadoop-compatibility ......................... SUCCESS [ 17.754 s]
[INFO] flink-contrib ...................................... SUCCESS [ 1.082 s]
[INFO] flink-statebackend-rocksdb ......................... SUCCESS [01:15 min]
[INFO] flink-tests ........................................ SUCCESS [08:00 min]
[INFO] flink-streaming-scala .............................. SUCCESS [ 56.492 s]
[INFO] flink-streaming-connectors ......................... SUCCESS [ 2.310 s]
[INFO] flink-connector-flume .............................. SUCCESS [ 10.413 s]
[INFO] flink-libraries .................................... SUCCESS [ 1.307 s]
[INFO] flink-table ........................................ SUCCESS [03:36 min]
[INFO] flink-metrics-jmx .................................. SUCCESS [ 8.609 s]
[INFO] flink-connector-kafka-base ......................... SUCCESS [ 13.582 s]
[INFO] flink-connector-kafka-0.8 .......................... SUCCESS [03:42 min]
[INFO] flink-connector-kafka-0.9 .......................... SUCCESS [03:53 min]
[INFO] flink-connector-elasticsearch ...................... SUCCESS [ 37.185 s]
[INFO] flink-connector-elasticsearch2 ..................... SUCCESS [ 46.210 s]
[INFO] flink-connector-rabbitmq ........................... SUCCESS [ 8.074 s]
[INFO] flink-connector-twitter ............................ SUCCESS [ 12.098 s]
[INFO] flink-connector-nifi ............................... SUCCESS [ 6.576 s]
[INFO] flink-connector-cassandra .......................... SUCCESS [02:32 min]
[INFO] flink-connector-redis .............................. SUCCESS [ 13.672 s]
[INFO] flink-connector-filesystem ......................... SUCCESS [ 58.438 s]
[INFO] flink-avro ......................................... SUCCESS [ 24.565 s]
[INFO] flink-jdbc ......................................... SUCCESS [ 11.221 s]
[INFO] flink-hbase ........................................ SUCCESS [ 15.708 s]
[INFO] flink-hcatalog ..................................... SUCCESS [ 26.367 s]
[INFO] flink-examples-streaming ........................... SUCCESS [ 52.331 s]
[INFO] flink-gelly ........................................ SUCCESS [01:02 min]
[INFO] flink-gelly-scala .................................. SUCCESS [ 46.746 s]
[INFO] flink-gelly-examples ............................... SUCCESS [ 36.253 s]
[INFO] flink-python ....................................... SUCCESS [01:43 min]
[INFO] flink-ml ........................................... SUCCESS [02:05 min]
[INFO] flink-cep .......................................... SUCCESS [ 24.554 s]
[INFO] flink-cep-scala .................................... SUCCESS [ 18.861 s]
[INFO] flink-scala-shell .................................. SUCCESS [01:10 min]
[INFO] flink-quickstart ................................... SUCCESS [ 3.737 s]
[INFO] flink-quickstart-java .............................. SUCCESS [ 8.546 s]
[INFO] flink-quickstart-scala ............................. SUCCESS [ 2.309 s]
[INFO] flink-storm ........................................ SUCCESS [ 29.819 s]
[INFO] flink-storm-examples ............................... SUCCESS [01:28 min]
[INFO] flink-apache-storm ................................. SUCCESS [ 34.629 s]
[INFO] flink-apache-storm-examples ........................ SUCCESS [02:43 min]
[INFO] flink-streaming-contrib ............................ SUCCESS [ 14.894 s]
[INFO] flink-tweet-inputformat ............................ SUCCESS [ 8.222 s]
[INFO] flink-operator-stats ............................... SUCCESS [ 15.517 s]
[INFO] flink-connector-wikiedits .......................... SUCCESS [ 18.067 s]
[INFO] flink-mesos ........................................ FAILURE [01:06 min]
[INFO] flink-yarn ......................................... SKIPPED
[INFO] flink-dist ......................................... SKIPPED
[INFO] flink-metrics-dropwizard ........................... SKIPPED
[INFO] flink-metrics-ganglia .............................. SKIPPED
[INFO] flink-metrics-graphite ............................. SKIPPED
[INFO] flink-metrics-statsd ............................... SKIPPED
[INFO] flink-fs-tests ..................................... SKIPPED
[INFO] flink-java8 ........................................ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:05 h
[INFO] Finished at: 2016-09-01T12:00:08+00:00
[INFO] Final Memory: 200M/988M
[INFO] ------------------------------------------------------------------------
Waiting for Jenkins to finish collecting data
[ERROR] Failed to execute goal org.scalastyle:scalastyle-maven-plugin:0.8.0:check (default) on project flink-mesos_2.10: Failed during scalastyle execution: You have 1 Scalastyle violation(s). -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :flink-mesos_2.10
```
Run flink-mesos, but I didn't modify the code in flink-mesos.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2452
@liuyuzhong Because we proceed with #2439 , can you close this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2452
There is not a lot of response on the mailing list. Apparently switching to the newer Storm version does not bother anyone.
My guess would be to switch to Strom 1.0+ and remove the storm 0.8/0.9 code.
What do others think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2452
@liuyuzhong Should be caused by bumping the Scalastyle version from 0.5.0 to 0.8.0. Doesn't occur on my machine though :( Investigating. Probably lowering the Scalastyle version again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Posted by liuyuzhong <gi...@git.apache.org>.
Github user liuyuzhong commented on the issue:
https://github.com/apache/flink/pull/2452
@mxm
Yes, all of this code are copy from old code adapted to Strom 1.0.0. So we close this pull request and wait for decision?
Actually, I was submit a pull request for old code adpate to storm version to 1.0.0.
https://github.com/apache/flink/pull/2439
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Posted by liuyuzhong <gi...@git.apache.org>.
Github user liuyuzhong commented on the issue:
https://github.com/apache/flink/pull/2452
ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2452
It looks like this is basically a copy of the old code adapted to the Storm 1.0.0 dependency. This would duplicate a lot of code. I've started a thread on the mailing list, whether we want to add a new module for Storm 1.0.0 or stop supporting old Storm versions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2452
@liuyuzhong Let's wait a couple more days for the community to respond. You don't have to close the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Posted by liuyuzhong <gi...@git.apache.org>.
Github user liuyuzhong commented on the issue:
https://github.com/apache/flink/pull/2452
Test Result (\u5931\u8d25)
```
org.apache.flink.api.scala.runtime.taskmanager.TaskManagerFailsITCase.The JobManager should detect a failing task manager
org.apache.flink.api.scala.runtime.taskmanager.TaskManagerFailsITCase.The JobManager should handle gracefully failing task manager
org.apache.flink.api.scala.runtime.taskmanager.TaskManagerFailsITCase.The JobManager should handle hard failing task manager
org.apache.flink.api.scala.runtime.taskmanager.TaskManagerFailsITCase.The JobManager should go into a clean state in case of a TaskManager failure
org.apache.flink.test.cancelling.MapCancelingITCase.testSlowMapCancelling
org.apache.flink.test.cancelling.MapCancelingITCase.testMapCancelling
org.apache.flink.test.cancelling.MapCancelingITCase.testMapPriorToFirstRecordReading
org.apache.flink.test.cancelling.MapCancelingITCase.testMapWithLongCancellingResponse
org.apache.flink.test.checkpointing.CoStreamCheckpointingITCase.org.apache.flink.test.checkpointing.CoStreamCheckpointingITCase
org.apache.flink.test.checkpointing.EventTimeAllWindowCheckpointingITCase.org.apache.flink.test.checkpointing.EventTimeAllWindowCheckpointingITCase
org.apache.flink.test.checkpointing.SavepointITCase.testTriggerSavepointAndResume
org.apache.flink.test.checkpointing.SavepointITCase.testCheckpointsRemovedWithJobManagerBackendOnShutdown
org.apache.flink.test.classloading.ClassLoaderITCase.testDisposeSavepointWithCustomKvState
org.apache.flink.test.exampleScalaPrograms.WordCountITCase.testJobWithoutObjectReuse
org.apache.flink.test.exampleScalaPrograms.WordCountITCase.testJobWithObjectReuse
org.apache.flink.test.failingPrograms.JobSubmissionFailsITCase.org.apache.flink.test.failingPrograms.JobSubmissionFailsITCase
org.apache.flink.test.recovery.TaskManagerProcessFailureBatchRecoveryITCase.testTaskManagerProcessFailure[0]
org.apache.flink.test.web.WebFrontendITCase.org.apache.flink.test.web.WebFrontendITCase
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Posted by liuyuzhong <gi...@git.apache.org>.
Github user liuyuzhong commented on the issue:
https://github.com/apache/flink/pull/2452
That's OK. I understand.
It's not so easy to make a decesion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Posted by liuyuzhong <gi...@git.apache.org>.
Github user liuyuzhong commented on the issue:
https://github.com/apache/flink/pull/2452
@mxm OK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Posted by liuyuzhong <gi...@git.apache.org>.
Github user liuyuzhong commented on the issue:
https://github.com/apache/flink/pull/2452
Jenkins run error:
```
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 30.585 sec - in org.apache.flink.test.recovery.TaskManagerProcessFailureStreamingRecoveryITCase
Running org.apache.flink.test.checkpointing.UdfStreamOperatorCheckpointingITCase
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 40.442 sec - in org.apache.flink.test.recovery.FastFailuresITCase
Running org.apache.flink.test.checkpointing.RescalingITCase
ERROR: Maven JVM terminated unexpectedly with exit code 137
Putting comment on the pull request
Finished: FAILURE
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2452
Sorry for chiming in late. Left some comments on the ML thread.
Overall I think it's ok to switch focus on supporting 1.0+ Storm versions only.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Posted by liuyuzhong <gi...@git.apache.org>.
Github user liuyuzhong commented on the issue:
https://github.com/apache/flink/pull/2452
build success
```
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:28 h
[INFO] Finished at: 2016-09-05T04:07:42+00:00
[INFO] Final Memory: 195M/581M
```
but Finished: UNSTABLE
```
[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/flink-github-ci/flink-contrib/flink-streaming-contrib/target/flink-streaming-contrib_2.10-1.2-SNAPSHOT-javadoc.jar to org.apache.flink/flink-streaming-contrib_2.10/1.2-SNAPSHOT/flink-streaming-contrib_2.10-1.2-SNAPSHOT-javadoc.jar
channel stopped
Putting comment on the pull request
Finished: UNSTABLE
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2452
I think you ran out of memory. Travis CI build passed, so the PR's testing state seems to be fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---